From xemacs-m  Sun Jun 22 17:21:05 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id RAA19534
	for <xemacs-beta@xemacs.org>; Sun, 22 Jun 1997 17:21:04 -0500 (CDT)
Received: (from hniksic@localhost)
          by jagor.srce.hr (8.8.5/8.8.4)
	  id AAA00952; Mon, 23 Jun 1997 00:21:04 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: [PATCH] live-icon and balloon-help
References: <199706221126.EAA15329@bittersweet.inetarena.com> <QQcvbb10244.199706221547@crystal.WonderWorks.COM> <877mfmb9j7.fsf@bittersweet.inetarena.com>
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 23 Jun 1997 00:21:04 +0200
In-Reply-To: karlheg@inetarena.com's message of "22 Jun 1997 14:41:16 -0700"
Message-ID: <kigen9uqnxr.fsf_-_@jagor.srce.hr>
Lines: 64
X-Mailer: Gnus v5.4.59/XEmacs 20.3(beta8) - "Copenhagen"

karlheg@inetarena.com (Karl M. Hegbloom) writes:

> `live-icon' is trying to make an icon for the balloon help frames.
> What needs to happen is that the unmap-screen-hook for the balloon
> helps needs to have the live-icon-one-frame removed, OR,
> live-icon-one-frame needs to check if the frame is a balloon (or
> dialog) and not try to make an icon for it.

The patches below should do it (untested!).  Note that this is by no
means a "real" fix -- it's more of a workaround.  We still do not know
what crashes XEmacs.

1997-06-23  Hrvoje Niksic  <hniksic@srce.hr>

	* utils/live-icon.el (live-icon-one-frame): Don't set glyphs to
	balloon-help frames.

	* packages/balloon-help.el (balloon-help-make-help-frame): Set the
	`balloon-help' property to the newly created frame.


--- lisp/packages/balloon-help.el.orig	Mon Jun 23 00:14:14 1997
+++ lisp/packages/balloon-help.el	Mon Jun 23 00:14:30 1997
@@ -479,7 +479,8 @@
 			       (cons 'minibuffer
 				     (minibuffer-window junk-frame))
 			       '(width . 3)
-			       '(height . 1)))))
+			       '(height . 1)
+			       '(balloon-help . t)))))
       (set-face-font 'default balloon-help-font frame)
       (set-face-foreground 'default balloon-help-foreground frame)
       (set-face-background 'default balloon-help-background frame)
--- lisp/utils/live-icon.el.orig	Mon Jun 23 00:15:58 1997
+++ lisp/utils/live-icon.el	Mon Jun 23 00:16:58 1997
@@ -125,9 +125,10 @@
 (defun live-icon-one-frame (&optional frame)
   "Gives FRAME (defaulting to (selected-frame)) a live icon."
   (interactive)
-  (if (not frame)
-      (setq frame (selected-frame)))
-  (set-glyph-image frame-icon-glyph (live-icon-from-frame frame) frame))
+  (unless frame
+    (setq frame (selected-frame)))
+  (unless (frame-property frame 'balloon-help)
+    (set-glyph-image frame-icon-glyph (live-icon-from-frame frame) frame)))
 
 ;;(defun live-icon-all-frames ()
 ;;  "Gives all your frames live-icons."
@@ -138,7 +139,7 @@
 ;;			       fr))
 ;;	  (frame-list)))
 
-(add-hook 'unmap-screen-hook 'live-icon-one-frame)
+(add-hook 'unmap-frame-hook 'live-icon-one-frame)
 ;;(start-itimer "live-icon" 'live-icon-all-frames 120 120)
 
 (provide 'live-icon)


-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Which is worse: ignorance or apathy?  Who knows?  Who cares?

