From xemacs-m  Fri Jan  3 15:56:52 1997
Received: from steadfast.teradyne.com (steadfast.teradyne.com [131.101.1.200])
          by xemacs.cs.uiuc.edu (8.8.4/8.8.4) with ESMTP
	  id PAA04017 for <xemacs-beta@xemacs.org>; Fri, 3 Jan 1997 15:56:51 -0600 (CST)
Received: from kiki.icd.teradyne.com (kiki.icd.teradyne.com [131.101.1.30]) by steadfast.teradyne.com (8.7.1/8.7.1) with ESMTP id QAA23177 for <xemacs-beta@xemacs.org>; Fri, 3 Jan 1997 16:59:47 -0500 (EST)
Received: from spacely.icd.teradyne.com (spacely.icd.teradyne.com [131.101.10.9]) by kiki.icd.teradyne.com (8.7.1/8.7.1) with SMTP id QAA20093 for <xemacs-beta@xemacs.org>; Fri, 3 Jan 1997 16:54:21 -0500 (EST)
Received: from spacely by spacely.icd.teradyne.com (SMI-8.6/SMI-SVR4)
	id QAA02394; Fri, 3 Jan 1997 16:56:27 -0500
Message-Id: <199701032156.QAA02394@spacely.icd.teradyne.com>
X-Mailer: exmh version 2.0beta 12/23/96
To: xemacs-beta@xemacs.org
Subject: Re: gnuserv frame (and detached minibuffer) 
In-reply-to: steve's message of 03 Jan 1997 11:23:06 -0800.
	     <m2d8vmy351.fsf@altair.xemacs.org> 
reply-to: acs@acm.org
Mime-Version: 1.0
Content-Type: multipart/mixed ;
	boundary="==_Exmh_12250601100"
Date: Fri, 03 Jan 1997 16:56:26 -0500
From: Vinnie Shelton  <shelton@icd.teradyne.com>

This is a multipart MIME message.

--==_Exmh_12250601100
Content-Type: text/plain; charset=us-ascii

OK.  I made the changes to support a gnuserv option.  This patch is against 
19.15b6.  A couple of comments:

1) It adds an autoload to gnuserv.el for gnuserv-frame, so until the 
loaddefs generation stuff works, this will have to be patched by hand.

2) I'm not particularly happy with the menu item title "Other Window 
Location" - it seems to have less relevance to its contents than ever.

3) I added a form to save the value of gnuserv-frame as '(selected-frame)
if gnuserv-frame is non-nil at the time the options are saved.  This is 
probably what most newbies want (not to create a new frame for every 
gnuclient call), however, if Jane experienced user explicitly sets 
gnuserv-frame to some fancy value in her .emacs file, this could over-write 
that value, depending upon where the .xemacs-options file is sourced.  I 
can't really think of a good way around this, and it would be obvious to an 
experienced user what happened, but I'm mentioning this here to see if 
_you_ have a better idea.

The commentary is longer than the patch.

--vin


--==_Exmh_12250601100
Content-Type: application/octet-stream ; name="diffs"
Content-Description: diffs
Content-Disposition: attachment; filename="diffs"

*** lisp/x11/x-menubar.el.orig	Sat Dec 28 19:15:23 1996
--- lisp/x11/x-menubar.el	Fri Jan  3 16:33:28 1997
***************
*** 225,230 ****
--- 225,238 ----
  	(setq temp-buffer-show-function nil)
  	:style radio
  	:selected (null temp-buffer-show-function)]
+        "-----"
+        ["Make current frame gnuserv target"
+ 	(setq gnuserv-frame
+ 	      (if (equal gnuserv-frame (selected-frame))
+ 		  nil
+ 		(selected-frame)))
+ 	:style radio
+ 	:selected (equal gnuserv-frame (selected-frame))]
         )
  
        "-----"
***************
*** 982,987 ****
--- 990,997 ----
       ;; Other Window Location
       get-frame-for-buffer-default-instance-limit
       temp-buffer-show-function
+      (if gnuserv-frame
+ 	 '(setq gnuserv-frame (selected-frame)))
  
       ;; Syntax Highlighting
       font-lock-auto-fontify
*** lisp/packages/gnuserv.el.orig	Fri Jan  3 16:18:09 1997
--- lisp/packages/gnuserv.el	Fri Jan  3 16:16:57 1997
***************
*** 66,71 ****
--- 66,72 ----
  	 (not (featurep 'gnuserv)))
      (error "Can't run gnuserv because server.el appears to be loaded already"))
  
+ ;;;###autoload
  (defvar gnuserv-frame nil
    "*If non-nil, the frame to be used to display all edited files.
  If nil, then a new frame is created for each file edited.

--==_Exmh_12250601100--


