From xemacs-m  Sat Dec 28 16:24:01 1996
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
          by xemacs.cs.uiuc.edu (8.8.4/8.8.4) with ESMTP
	  id QAA06218 for <xemacs-beta@xemacs.org>; Sat, 28 Dec 1996 16:24:00 -0600 (CST)
Received: (from steve@localhost)
          by altair.xemacs.org (8.8.4/8.8.4)
	  id OAA10409; Sat, 28 Dec 1996 14:34:30 -0800
Sender: steve@xemacs.org
To: xemacs-beta@xemacs.org
Subject: Re: xemacs-19.15b4/b4 report for NEXTSTEP
References: <199612281122.MAA18514@sol1.cybernet-ag.net> 	<m2681mbhif.fsf@altair.xemacs.org> <199612282012.MAA05102@xemacs.eng.sun.com>
X-Url: http://www.miranova.com/%7Esteve/
Mail-Copies-To: never
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@miranova.com>
In-Reply-To: Martin Buchholz's message of Sat, 28 Dec 1996 12:12:47 -0800
Date: 28 Dec 1996 14:34:30 -0800
Message-ID: <m24th6wb61.fsf@altair.xemacs.org>
Lines: 55
X-Mailer: Red Gnus v0.72/XEmacs 19.15

>>>>> "Martin" == Martin Buchholz <mrb@eng.sun.com> writes:

>>>>> "Steven" == Steven L Baur <steve@miranova.com> writes:
>>>>> "Axel" == Axel Seibert <aseibert@cybernet-ag.net> writes:
Axel> typedef SIGTYPE (*signal_handler_t) (int);

Martin> Looks harmless enough. Please dig some more. Often examining
Martin> the source files after it's been pre-processed is useful.

Steven> Here is the patch that was applied to beta4:

Steven> Index: syssignal.h
Steven> +typedef SIGTYPE (*signal_handler_t) (int);

Martin> OK, I vaguely remember doing that now, as part of my quest for
Martin> warning-free compiles.  It's a non-functional change, and can
Martin> be undone if we want to.

Thu Dec 19 00:44:10 1996  Bart Robinson  <lomew@cs.utah.edu>

        * syssignal.h: The declaration of SIGTYPE shouldn't be protected
        by HAVE_SIGPROCMASK.

As I recall, Bart bombed on compile because of the invisibility of that
typedef when HAVE_SIGPROCMASK was undefined.  This is very much a
functional change ...

Martin> The line:

Martin> #define signal_handler_t int

Martin> in next.h and nextstep.h looks very suspect - signal_handler_t is
Martin> supposed to be a function type, not an integral type.

This looks more correct.  Or rather, that #define looks pretty bogus.
We might have inherited that code from Emacs, but it's not there in
19.34.

Martin> Axel, perhaps you want to take another look at the header
Martin> files.  Type correctness is worth it in the long run.  If you
Martin> really need to have this change undone, we'll make it so.

If you keep the #define signal_handler_t, you will need:

#ifndef signal_handler_t
typedef SIGTYPE (*signal_handler_t) (int);
#endif

Or try wiping out the #define altogether in next.h.  That's the
preferred solution.
-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be billed at $250/message.
"That Bill Clinton.  He probably doesn't know how to log on to the
Internet."  -- Rush Limbaugh, noted Computer Expert

