From xemacs-m  Thu Apr 10 04:04:27 1997
Received: from elc1.dina.kvl.dk (elc1.dina.kvl.dk [130.225.40.228])
	by xemacs.org (8.8.5/8.8.5) with SMTP id EAA20397
	for <xemacs-beta@xemacs.org>; Thu, 10 Apr 1997 04:04:26 -0500 (CDT)
Received: from zuse.dina.kvl.dk (zuse.dina.kvl.dk [130.225.40.245]) by elc1.dina.kvl.dk (8.6.12/8.6.4) with ESMTP id LAA22828; Thu, 10 Apr 1997 11:04:08 +0200
Received: (abraham@localhost) by zuse.dina.kvl.dk (8.6.12/8.6.4) id LAA25175; Thu, 10 Apr 1997 11:04:10 +0200
Sender: abraham@dina.kvl.dk
To: Hrvoje Niksic <hniksic@srce.hr>
Cc: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: make-mode.el is customized
References: <kig7mibdexh.fsf@jagor.srce.hr>
Organization: The Church of Emacs
X-Face: +kRV2]2q}lixHkE{U)mY#+6]{AH=yN~S9@IFiOa@X6?GM<U{B+4e{k79.Ya{~':DblFPCg$
 @60,BfLv2@SKZ19cMWK0/C'v;tM:|6B'R}U1rp6CL&kN({9<zF/V{:JCg27yC)9oZjeqcQawzKfiNL
 t9}`vjmK["dRQC/qGFQq"%u|Q`:6{"Rz}b(dnl_"3$Jtqimi>|8MBp/
From: Per Abrahamsen <abraham@dina.kvl.dk>
Date: 10 Apr 1997 11:04:10 +0200
In-Reply-To: Hrvoje Niksic's message of 10 Apr 1997 00:11:54 +0200
Message-ID: <rjiv1v1c6t.fsf@zuse.dina.kvl.dk>
Lines: 52
X-Mailer: Gnus v5.4.37/Emacs 19.34
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hrvoje Niksic <hniksic@srce.hr> writes:

> Even if you don't test the other changes, please try testing the
> defcustom for `makefile-space-face' (you can evaluate it independently
> and use `M-x customize-face').  This is my first try at `defface'.

Ok.

> -(defvar makefile-space-face 'makefile-space-face
> -  "Face to use for highlighting leading spaces in Font-Lock mode.")

To be compatible with people who have set this variable:

(defcustom makefile-space-face 'makefile-space-face
  "Face to use for highlighting leading spaces in Font-Lock mode."
  :type 'face
  :group 'makefile-mode)

> +(defface makefile-space-face
> +  '((((class color))
> +     (:background "hotpink"))		; uhm
> +    (((class grayscale)
> +      (background light))
> +     (:background "black"))
> +    (((class grayscale)
> +      (background black))

dark, not black.

> +     (:background "white"))
> +    (((class mono)
> +      (background light))
> +     (:background "white"))
> +    (((class mono)
> +      (background dark))
> +     (:background "black")))
> +  "Face to use for highlighting leading spaces in Font-Lock mode."
> +  :group 'makefile-mode)

(defface makefile-space-face
  '((((class color))
     (:background "hotpink"))		; Yeah!
    ;; Everything else, just choose the most visible background
    ;; color.  We don't care about foreground, since it is only used
    ;; for whitespace.
    (((background light))
      (:background "black"))
    (((background dark))
      (:background "white")))
  "Face to use for highlighting leading spaces in Font-Lock mode."
  ;; Don't add a :group, since people can access it through the variable.
  )

