From xemacs-m  Mon Apr  7 04:47:36 1997
Received: from elc1.dina.kvl.dk (elc1.dina.kvl.dk [130.225.40.228])
	by xemacs.org (8.8.5/8.8.5) with SMTP id EAA20687
	for <xemacs-beta@xemacs.org>; Mon, 7 Apr 1997 04:47:35 -0500 (CDT)
Received: from zuse.dina.kvl.dk (zuse.dina.kvl.dk [130.225.40.245]) by elc1.dina.kvl.dk (8.6.12/8.6.4) with ESMTP id LAA07099; Mon, 7 Apr 1997 11:36:18 +0200
Received: (abraham@localhost) by zuse.dina.kvl.dk (8.6.12/8.6.4) id LAA18389; Mon, 7 Apr 1997 11:47:33 +0200
Sender: abraham@dina.kvl.dk
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: facemenu and `M-g'
References: <kigpvw8gnwy.fsf@jagor.srce.hr> <rvhghjztys.fsf@sdnp5.ucsd.edu> <m2k9mf7osd.fsf@altair.xemacs.org> <kigpvw7lqr8.fsf@jagor.srce.hr> <y9lg1x32x20.fsf@modas.informatik.uni-tuebingen.de> <kign2rbnycq.fsf@jagor.srce.hr> <y9lbu7r2v3k.fsf@modas.informatik.uni-tuebingen.de> <kigencnnx3b.fsf@jagor.srce.hr> <m2pvw7454y.fsf@altair.xemacs.org> <kigiv1z9qg9.fsf@jagor.srce.hr>
Organization: The Church of Emacs
X-Face: +kRV2]2q}lixHkE{U)mY#+6]{AH=yN~S9@IFiOa@X6?GM<U{B+4e{k79.Ya{~':DblFPCg$
 @60,BfLv2@SKZ19cMWK0/C'v;tM:|6B'R}U1rp6CL&kN({9<zF/V{:JCg27yC)9oZjeqcQawzKfiNL
 t9}`vjmK["dRQC/qGFQq"%u|Q`:6{"Rz}b(dnl_"3$Jtqimi>|8MBp/
From: Per Abrahamsen <abraham@dina.kvl.dk>
Date: 07 Apr 1997 11:47:32 +0200
In-Reply-To: Hrvoje Niksic's message of 07 Apr 1997 10:39:50 +0200
Message-ID: <rj7mifw4ej.fsf@zuse.dina.kvl.dk>
Lines: 21
X-Mailer: Gnus v5.4.37/Emacs 19.34
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


The current code doesn't make any sense.  It doesn't bind `M-g' by
default, but bind it once `facemenu.el' is loaded.  This provides
neither consistency with Emacs, nor does it allow the user to rebind
the key in an obvious way.  

I suggest you restore the Emacs default binding, like this:

	;;; Provide some binding for startup:
	;;;###autoload (define-key global-map "\M-g" 'facemenu-keymap)
	;;;###autoload (autoload 'facemenu-keymap "facemenu" "Keymap for face-changing commands." t 'keymap)

but remove the last line from `facemenu-update', where the key is
unnecessarily bound again:

	(if facemenu-key (define-key global-map facemenu-key 'facemenu-keymap))

This will give an Emacs compatible key binding, _and_ allow the user
to change it with a `global-set-key' in his `.emacs'.

The current behaviour gives neither.

