From xemacs-m  Mon Mar 10 13:07:03 1997
Received: from corona.pixar.com (corona.pixar.com [138.72.20.84])
	by xemacs.org (8.8.5/8.8.5) with SMTP id NAA02081
	for <xemacs-beta@xemacs.org>; Mon, 10 Mar 1997 13:07:02 -0600 (CST)
Received: by corona.pixar.com (Smail3.1.29.1 #2)
	id m0w4AN5-0001XtC; Mon, 10 Mar 97 11:04 PST
Sender: retnuh@pixar.com (Hunter Kelly)
Sender: retnuh@corona
To: Per Abrahamsen <abraham@dina.kvl.dk>
Cc: xemacs-beta@xemacs.org
Subject: Re: more fonst madness! [WAS Re: 20.1-b5: Setting fonts?]
References: <199703062143.QAA07193@spacely.icd.teradyne.com> 	<m3afog31we.fsf@jens.metrix.de> <199703071540.KAA05372@anthem.CNRI.Reston.Va.US> <yvtybbz82il.fsf@corona.pixar.com> <m24tenvv2t.fsf@altair.xemacs.org> <yvtvi737xh7.fsf_-_@corona.pixar.com> <rjendqvh08.fsf@zuse.dina.kvl.dk>
Mime-Version: 1.0 (generated by tm-edit 7.105)
Content-Type: text/plain; charset=US-ASCII
From: Hunter Kelly <retnuh@corona.pixar.com>
Date: 10 Mar 1997 11:04:30 -0800
In-Reply-To: Per Abrahamsen's message of 08 Mar 1997 11:02:15 +0100
Message-ID: <yvtsp238t6p.fsf@corona.pixar.com>
Lines: 28
X-Mailer: Gnus v5.4.17/XEmacs 19.15

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> Hunter Kelly <retnuh@corona.pixar.com> writes:
> 
> > +		      (if (not (or (get face 'saved-face)
> 
> Prevents edit-faces from saving faces that have also been explicitly
> modified and saved by the user with customize.  Obviously a good
> thing.

Right.

> > +				   (get face 'factory-face)))
> 
> Prevents edit-faces from saving any face that has been declared with
> the `defface' macro.  I'm not sure what the benefit of this will be.

Hmmm. The idea was that if a face is defined in a package, it needn't
be saved out to .xemacs-options.  Of course, this doesn't take into
account whether the user has changed the face or not via edit-faces.
This is a mistake on my part, and should probably be taken out.
Thanks for pointing this out, Per.

Man, I am tired of the mess that edit-faces causes/has caused.  Blech.

Steven, do you want me to whip up a patch to fix the above error?

Hunter

