From xemacs-m  Tue Feb 18 04:57:34 1997
Received: from minerva.tentstraat.nl (root@d06.din.cuci.nl [195.240.25.39])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id EAA26315
	for <xemacs-beta@xemacs.org>; Tue, 18 Feb 1997 04:57:31 -0600 (CST)
Received: (from hfranz@localhost) by minerva.tentstraat.nl (8.7.5/8.7.3) id LAA05139; Tue, 18 Feb 1997 11:53:26 +0100
Sender: hfranz@minerva.cuci.nl
To: jens@lemming0.lem.uni-karlsruhe.de
Cc: xemacs-beta@xemacs.org
Subject: Re: Loose ends -- tm in-line image patch/fun with glyphs
References: <199702171850.NAA03658@spacely.icd.teradyne.com> <m3d8tzt733.fsf@jens.metrix.de>
From: Holger Franz <hfranz@cuci.nl>
In-Reply-To: Jens Lautenbacher's message of 17 Feb 1997 23:12:48 +0100
Mime-Version: 1.0 (generated by tm-edit 7.101)
Content-Type: text/plain; charset=US-ASCII
Date: 18 Feb 1997 11:53:24 +0100
Message-ID: <m3iv3qidwb.fsf@minerva.tentstraat.nl>
Lines: 31
X-Mailer: Gnus v5.4.12/XEmacs 19.14


>>>>> "Jens" == Jens Lautenbacher <jens@metrix.de> writes:

 Jens> Just a little advanced version... this one actually works
 Jens> (view-mode-enter instead of view-mode ) without annoying
 Jens> messages and removes the binary garbage.

I never thought that this hack would make it into the general XEmacs
public. It now looks very good indeed, maybe it could qualify as a
/micro-package/ for the 19.15 release?

\begin{nit-picking}

'view-image-mode' and 'view-image' could use a (require 'view), just
to be sure that view-mode-enter is defined (it isn't autoloaded at
least in my 19.14er).

Now I get an error "Symbol's value as variable is void:
view-prev-buffer" when I press 'q' to exit view-image-mode. Does
anybody else see this behaviour?

Is the explicit use of (garbage-collect) useful? What mechanism does
XEmacs use with respect to freeing up colourmap entries? When I whipped
this code up I did some experimenting and found that an explicit gc is
the fastest way, but is it good style? 

\end{nit-picking}

-- 
Holger Franz <hfranz@cuci.nl>
             <hfranz@physik.rwth-aachen.de>

