From xemacs-m  Tue Feb  4 13:06:31 1997
Received: from alphatech.com (erebus.alphatech.com [198.112.236.2])
	by xemacs.org (8.8.5/8.8.5) with SMTP id NAA07268
	for <xemacs-beta@xemacs.org>; Tue, 4 Feb 1997 13:06:30 -0600 (CST)
Received: from venus.alphatech.com by alphatech.com (4.1/SMI-4.1)
	id AA27915; Tue, 4 Feb 97 14:02:15 EST
Received: from pochacco.alphatech.com by venus.alphatech.com (4.1/SMI-4.1)
	id AA24268; Tue, 4 Feb 97 14:09:45 EST
Received: by pochacco.alphatech.com (SMI-8.6/SMI-SVR4)
	id OAA22287; Tue, 4 Feb 1997 14:01:04 -0500
Sender: greg@pochacco.alphatech.com
From: greg@alphatech.com (Greg Klanderman)
To: xemacs-beta@xemacs.org
Subject: Re: [20.0] bug in makefile mode
References: <vku3nt35t0.fsf@cdc.noaa.gov> <m23evd9y0c.fsf@altair.xemacs.org>
Reply-To: greg@alphatech.com
Date: 04 Feb 1997 14:01:04 -0500
In-Reply-To: Steven L Baur's message of 03 Feb 1997 17:10:43 -0800
Message-Id: <ugenew4cr3.fsf@pochacco.alphatech.com>
Lines: 44
X-Mailer: Gnus v5.2.40/XEmacs 19.15


>>>>> "sb" == Steven L Baur <steve@miranova.com> writes:
sb> Mark Borges writes:
>> 1. xemacs -q
>> 2. edit a Makefile
>> 3. Invoke makefile-switch-to-browser (bound to \C-c \C-b). I have no
>> idea what this does, or why one would want to do it, but it
>> triggers this:
>> ==>
>> Signaling: (error "Invalid converter character )")
sb> 
sb> Yup.
sb> 
sb> Index: make-mode.el
sb> ===================================================================
sb> RCS file: /usr/local/xemacs/xemacs-19.15/lisp/modes/make-mode.el,v
sb> retrieving revision 1.2
sb> diff -u -r1.2 make-mode.el
sb> --- make-mode.el	1997/01/11 22:10:07	1.2
sb> +++ make-mode.el	1997/02/04 01:09:15

I won't argue that its a bug to format the already formatted string.
The reason this arose however is due to the patch I sent Steve for
make-mode a couple weeks ago.  One thing this patch did was add the
makefile-runtime-macros-list to makefile-macro-table so that you
wouldn't have to confirm entry of runtime macros (since they were
never in the completion list).  They should probably be taken out for
use in the browser, this patch does that (tho I never use the browser).

Greg

--- /home/greg/.backups/!home!greg!packages!xemacs-beta!xemacs-19.15-b4!lisp!modes!make-mode.el.~2~	Tue Jan  7 12:07:17 1997
+++ /home/greg/packages/xemacs-beta/xemacs-19.15-b4/lisp/modes/make-mode.el	Tue Feb  4 13:54:08 1997
@@ -1108,7 +1108,9 @@
   (setq makefile-browser-client (current-buffer))
   (makefile-pickup-targets)
   (makefile-pickup-macros)
-  (makefile-browse makefile-target-table makefile-macro-table))
+  (makefile-browse makefile-target-table
+                   ;; take out the runtime macros which were added for completion sake -gk
+                   (set-difference makefile-macro-table makefile-runtime-macros-list)))
 
 
 

