From xemacs-m  Wed Aug 20 08:58:07 1997
Received: from newman.aventail.com (root@newman.aventail.com [199.238.236.1])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id IAA19204
	for <xemacs-beta@xemacs.org>; Wed, 20 Aug 1997 08:58:06 -0500 (CDT)
Received: from kramer.in.aventail.com (wmperry@kramer.in.aventail.com [192.168.1.12])
	by newman.aventail.com (8.8.5/8.8.5) with ESMTP id GAA12825;
	Wed, 20 Aug 1997 06:58:06 -0700 (PDT)
Received: (from wmperry@localhost)
	by kramer.in.aventail.com (8.8.5/8.8.5) id GAA13480;
	Wed, 20 Aug 1997 06:57:17 -0700
To: cognot@ensg.u-nancy.fr
Cc: xemacs-beta@xemacs.org
Subject: Re: Buglet : bad interaction: OOBR/W3
References: <199708201318.IAA19010@xemacs.org>
Errors-to: wmperry@aventail.com
Reply-to: wmperry@aventail.com
X-Face: O~Rn;(l][/-o1sALg4A@xpE:9-"'IR[%;,,!m7</SYF`{vYQ(&RI1&EiH[FvT;J}@f!4kfz
 x_!Y#=y{Uuj9GvUi=cPuajQ(Z42R[wE@{G,sn$qGr5g/wnb*"*ktI+,CD}1Z'wxrM2ag-r0p5I6\nA
 [WJopW_J.WY;
From: wmperry@aventail.com (William M. Perry)
Date: 20 Aug 1997 06:57:17 -0700
In-Reply-To: Richard Cognot's message of "Wed, 20 Aug 1997 09:17:35 -0400 (EDT)"
Message-ID: <86bu2tc5z6.fsf@kramer.in.aventail.com>
Lines: 56
X-Mailer: Gnus v5.4.64/XEmacs 20.3(beta18) - "Bratislava"

Richard Cognot <cognot@ensg.u-nancy.fr> writes:

> In br-menu.el, there is a test like this:
> 
> (cond ((null hyperb:window-system))
>       ((fboundp 'id-menubar-set)
> -----------------^^^^^^^^^^^^^^
>        ;; InfoDock under a window system
>        (require 'id-menubars)
>        (id-menubar-set 'br-mode 'id-menubar-br))
>       (hyperb:lemacs-p
>        ;; XEmacs under a window system
>        (add-hook 'br-mode-hook 'br-menubar-menu))
>       (hyperb:emacs19-p
>        ;; Emacs 19 under a window system
>        (require 'lmenu)
>        (add-hook 'br-mode-hook 'br-menubar-menu)))
> 
> Trouble is, W3 does fset id-menubar-set to 'ignore... Which of course
> makes oobr fail as id-menubars is not provided.
> 
> Shouldn't this be a (featurep 'infodock) instead? or should w3 avoid
> fset'ing this function...

 I should avoid fset'ing the function.

-Bill P.

Index: w3-menu.el
===================================================================
RCS file: /usr/people/wmperry/.cvs/w3/lisp/w3-menu.el,v
retrieving revision 1.41
diff -c -w -r1.41 w3-menu.el
*** w3-menu.el	1997/07/06 22:24:36	1.41
--- w3-menu.el	1997/08/20 14:00:36
***************
*** 35,44 ****
  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
  ;;; InfoDock stuff
  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
! (if (not (fboundp 'id-menubar-set))
!     (fset 'id-menubar-set 'ignore))
! 
! (id-menubar-set 'w3-mode 'w3-menu-make-xemacs-menubar)
  
  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
  ;;; Spiffy new menus (for both Emacs and XEmacs)
--- 35,42 ----
  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
  ;;; InfoDock stuff
  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
! (if (fboundp 'id-menubar-set)
!     (id-menubar-set 'w3-mode 'w3-menu-make-xemacs-menubar))
  
  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
  ;;; Spiffy new menus (for both Emacs and XEmacs)

