From xemacs-m  Sun Aug 17 17:23:23 1997
Received: from synaptics.synaptics.com (synaptics.synaptics.com [207.92.223.3])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id RAA25698
	for <xemacs-beta@xemacs.org>; Sun, 17 Aug 1997 17:23:22 -0500 (CDT)
Received: (from mail@localhost) by synaptics.synaptics.com (8.7.5/8.7.3) id PAA22853; Sun, 17 Aug 1997 15:22:39 -0700 (PDT)
X-Authentication-Warning: synaptics.synaptics.com: mail set sender to <daveg@thymus> using -f
Received: from synaptx.synaptics.com(192.147.44.16) by synaptics.synaptics.com via smap (V1.3)
	id sma022850; Sun Aug 17 15:22:32 1997
Received: from thymus.synaptics.com by synaptx.synaptics.com (4.1/SMI-4.1)
	id AA24262; Sun, 17 Aug 97 15:22:39 PDT
Received: by thymus.synaptics.com (4.1/SMI-4.1)
	id AA03426; Sun, 17 Aug 97 15:22:35 PDT
Message-Id: <9708172222.AA03426@thymus.synaptics.com>
To: karlheg@inetarena.com (Karl M. Hegbloom)
Cc: XEmacs Beta <xemacs-beta@xemacs.org>
Subject: Re: [patch] lisp/cl/cl-macs.el and man/cl.texi 
In-Reply-To: Your message of "15 Aug 97 22:36:35 PDT."
             <87yb623d0c.fsf@bittersweet.inetarena.com> 
Reply-To: daveg@synaptics.com
Date: Sun, 17 Aug 97 15:22:34 -0700
From: Dave Gillespie <daveg@synaptics.com>

Karl Hegbloom writes:

> (defun cl-make-type-test (val type)
> -  (if (memq type '(character string-char)) (setq type '(integer 0 255)))
> +  (if (fboundp 'characterp) ;; are characters a distinct type here?
> +      (when (eq type 'string-char) (setq type 'character))
> +    (when (memq type '(character string-char)) (setq type '(integer 0 255))))
>   ...

Close, but not quite:  If you use `when', then cl-macs.el will
not compile unless cl.el is already loaded.  Maybe that's okay,
but I consider it an undesirable interdependency.  The patch is
okay if you replace `when' with `if' in both places.

Here's my preferred version:

(defun cl-make-type-test (val type)
  (if (memq type '(character string-char))
      (setq type (if (fboundp 'characterp) 'character '(integer 0 255))))
  ...

It's more concise, and also it avoids calling `fboundp' for
type names other than `character' and `string-char'.

								-- Dave

