From xemacs-m  Fri Aug  1 20:42:17 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id UAA07366
	for <xemacs-beta@xemacs.org>; Fri, 1 Aug 1997 20:42:16 -0500 (CDT)
Received: (from steve@localhost)
	by altair.xemacs.org (8.8.6/8.8.6) id SAA18851;
	Fri, 1 Aug 1997 18:46:35 -0700
Mail-Copies-To: never
To: xemacs-beta@xemacs.org
Subject: [PATCH] Re: Hungarian problems: dired & eval.c
References: <rwxg1stwike.fsf@kopernik.npac.syr.edu>
X-Face: `'%\i;ySOu]g?NlziJSk_$&@]KP`}~PEQPjZ5;nxSaDW_o$4+4%Ab]%Ifw3ZR;7TIT3,O,'
 @2{L;]ox6kc;$_5kU'n**9vFg-]eV~GbxSVCx|(s%uR[],*:^WKmC`B}(;|k9/m]gwt?&`t;^rfCJg
 khHH>pP1W\)xM0U@!FNDD72{3fDP$PkBhx^7Z?-WxH6DbFN:QOnT`llzW}VGdYv;n9lzljQvKTIBhQ
 YuV
X-Attribution: sb
From: SL Baur <steve@xemacs.org>
In-Reply-To: Remek Trzaska's message of "01 Aug 1997 20:10:41 -0400"
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
Date: 01 Aug 1997 18:46:34 -0700
Message-ID: <m2k9i573wl.fsf@altair.xemacs.org>
Lines: 50
X-Mailer: Gnus v5.4.64/XEmacs 20.3(beta17) - "Bucharest"

Remek Trzaska <remek@npac.syr.edu> writes:

> Hi guys!
> Whenever I press 'f'  in dired in Budapest I get an error:

> Signaling: (wrong-type-argument stringp nil)
>   expand-file-name(nil)
>   find-file-noselect(nil)
>   find-file(nil nil)
              ^^^
>   dired-advertised-find-file(nil)
>   call-interactively(dired-advertised-find-file)

O.K.  I see this.  It appears `dired-get-filename' is failing.

> Is something wrong with me or with Budapest?  (yes, I start XEmacs
> with -q -no-site-file.)  The problem was not present in Berlin.

> The other problem was "volatile" in call_with_suspended_errors header
> declared in emacsfns.h, defined in eval.c, line 2127

> call_with_suspended_errors (lisp_fn_t fun, /*volatile*/ Lisp_Object retval,
> 			    Lisp_Object class, Error_behavior errb,
> 			    int nargs, ...)

> SGI's cc complained about incompatible declaration.

That's the wrong fix.  The `volatile' is there for a reason.


1997-08-01  SL Baur  <steve@altair.xemacs.org>

	* emacsfns.h: Fix declaration.

Index: src/emacsfns.h
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/src/emacsfns.h,v
retrieving revision 1.17
diff -u -r1.17 emacsfns.h
--- emacsfns.h	1997/07/26 22:10:14	1.17
+++ emacsfns.h	1997/08/02 01:42:03
@@ -691,7 +691,7 @@
 				   Lisp_Object object1,
 				   Lisp_Object object2);
 Lisp_Object call_with_suspended_errors (lisp_fn_t fun,
-					Lisp_Object retval,
+					volatile Lisp_Object retval,
 					Lisp_Object class,
 					Error_behavior errb,
 					int nargs, ...);

