From xemacs-m  Mon Jul 14 14:46:17 1997
Received: from mercury.Sun.COM (mercury.Sun.COM [192.9.25.1])
	by xemacs.org (8.8.5/8.8.5) with SMTP id OAA06637
	for <xemacs-beta@xemacs.org>; Mon, 14 Jul 1997 14:46:16 -0500 (CDT)
Received: from Corp.Sun.COM ([129.145.35.78]) by mercury.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id NAA29693 for <xemacs-beta@xemacs.org>; Mon, 14 Jul 1997 13:13:35 -0700
Received: from legba.Corp.Sun.COM by Corp.Sun.COM (SMI-8.6/SMI-5.3)
	id MAA15695; Mon, 14 Jul 1997 12:45:42 -0700
Received: by legba.Corp.Sun.COM (SMI-8.6/SMI-SVR4)
	id MAA00997; Mon, 14 Jul 1997 12:45:41 -0700
To: Hrvoje Niksic <hniksic@srce.hr>
Cc: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: pending-delete customization [PATCH]
References: <bci67ud5tse.fsf@corp.Sun.COM> <kig4t9xctxy.fsf@jagor.srce.hr>
X-Attribution: GDF
Mail-Copies-To: never
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
From: Gary.Foster@Corp.Sun.COM (Gary D. Foster)
Date: 14 Jul 1997 12:45:41 -0700
In-Reply-To: Hrvoje Niksic's message of "14 Jul 1997 21:30:49 +0200"
Message-ID: <bci20515sey.fsf@corp.Sun.COM>
Lines: 33
X-Mailer: Gnus v5.4.63/XEmacs 20.3(beta13) - "Brussels"

>>>>> "Hrv" == Hrvoje Niksic <hniksic@srce.hr> writes:


    Hrv> Steve, please don't apply this patch.  I feel that a group
    Hrv> for pending-delete is not necessary.  If the modeline string
    Hrv> is bad, we'll change it.

Maybe a group is unnecessary, but I don't see the purpose in
hardcoding the modeline string to anything.  I just copied the way
filladapt-mode handles it, which works great.

    >> +(defcustom pending-delete-mode nil "Non-nil when Pending
    >> Delete mode is enabled.  -In Pending Delete mode, typed text
    >> replaces the selected region.")  +In Pending Delete mode, typed
    >> text replaces the selected region."
    >> + :type 'boolean
    >> + :group 'pending-delete)

    Hrv> I don't think this is good.  Setting pending-delete-mode to
    Hrv> anything won't run the appropriate commands.

    Hrv> Now, how about this patch instead:

I don't like this because it is the same exact problem... all this
does is set the modeline string to nil when some people might want to
be able to set it to whatever they choose.

Remove the modeline toggle from the group if you want, change the
group if you want, but why hardcode the modeline string?  Someone is
always going to disagree with what we choose as the modeline string,
so let _them_ change it.

-- Gary F.

