From xemacs-m  Thu Jul 10 12:25:16 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id MAA10013
	for <xemacs-beta@xemacs.org>; Thu, 10 Jul 1997 12:25:15 -0500 (CDT)
Received: (from hniksic@localhost)
	by jagor.srce.hr (8.8.6/8.8.6) id TAA15734;
	Thu, 10 Jul 1997 19:25:16 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: gnuserv.el enhancement - "Done" button
References: <26337.868545147@kocrsw12> <kigpvsrc545.fsf@jagor.srce.hr> <bylo3eu9qc.fsf@midget.math.ethz.ch>
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 10 Jul 1997 19:25:15 +0200
In-Reply-To: Jan Vroonhof's message of "10 Jul 1997 18:56:27 +0200"
Message-ID: <kigg1tmddl0.fsf@jagor.srce.hr>
Lines: 58
X-Mailer: Gnus v5.4.59/XEmacs 20.3(beta12) - "Helsinki"

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> 
> > 1997-07-10  Hrvoje Niksic  <hniksic@srce.hr>
> > 
> > 	* packages/gnuserv.el (gnuserv-edit-files): Operate on this
> > 	buffer's menubar.
> > 
> 
> :-(, I just had gnuserv 3.7 working under FSF 19.34 using the file
> below.

Why don't you simply fork off a different gnuserv source that works
correctly under the FSF?  I don't think gnuserv.el will see any more
big changes in the near future (at least by me), so it shouldn't be
hard.

Also, it would spare you:

1) loads of necessary overkills -- for example, you'd probably be able 
   to get rid of much of the device/frame intricacies I have worked
   carefully to implement correctly;

2) dirtiness, like advising existing Emacs functions and devising new, 
   mulfunctioning ones (the emulation of the device interface);

3) woes, such as introducing XEmacs-specific source in the middle of
   the code.

> Could we move this menu stuff to a hook function that is by default on
> gnuserv-edit-hook and gnuserv-done-hook.

No, hooks should be `nil' by default, if at all possible.

> ... (The other alternative would be easy-menu but that would be
> overkill).

I don't think easymenu handles menu buttons correctly.

> P.P.S. Why the %$#@$@ does FSF Emacs not include functionp? Now there is
> gnuserv-functionp, message-functionp, gnus-functionp etc etc.

Emacs 20.1 has functionp.  But packages will probably keep defining it 
for ages.  Some packages still support Emacs 18.59, for that matter.

> P.P.P.S. I still am not sure the compatibilty variable stuff works
> well yet. In particular when the server-* variables are set before
> gnuserv gets loaded.

Neither am I.  If they don't work, I'd like them thrown out.  They are 
too ugly to keep them around if they are not useful.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
* Vi is the God of editors.
* Emacs is the editor of Gods.

