From xemacs-m  Thu Jul 10 03:11:02 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id DAA29252
	for <xemacs-beta@xemacs.org>; Thu, 10 Jul 1997 03:11:01 -0500 (CDT)
Received: (from steve@localhost)
	by altair.xemacs.org (8.8.6/8.8.6) id BAA12747;
	Thu, 10 Jul 1997 01:14:02 -0700
Mail-Copies-To: never
To: xemacs-beta@xemacs.org
Subject: Re: hide-ifdef again
References: <199707100516.BAA24011@spacely.icd.teradyne.com> <kig3epn4fzw.fsf@jagor.srce.hr> <m267uj74yl.fsf@altair.xemacs.org> <kigwwmzz733.fsf@jagor.srce.hr>
X-Url: http://www.miranova.com/%7Esteve/
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@xemacs.org>
In-Reply-To: Hrvoje Niksic's message of "10 Jul 1997 09:42:24 +0200"
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
Date: 10 Jul 1997 01:14:02 -0700
Message-ID: <m2vi2j5np1.fsf@altair.xemacs.org>
Lines: 44
X-Mailer: Gnus v5.4.62/XEmacs 20.3(beta13) - "Brussels"

Hrvoje Niksic <hniksic@srce.hr> writes:

> Steven L Baur <steve@xemacs.org> writes:
>> >  ;;;###autoload
>> > -(add-minor-mode 'hide-ifdef-mode " Ifdef" 'hide-ifdef-mode-map)
>> > +(add-minor-mode 'hide-ifdef-mode " Ifdef" hide-ifdef-mode-map)
>> 
>> There are two problems with this one line patch.  Problem number one
>> is that hide-ifdef-mode-map is not an autoload, so putting this code
>> into the autoloads is going to blow chunks at XEmacs dump time (void
>> variable hide-ifdef-mode-map).

> You are right.  The whole statement shouldn't be autoloaded at all,
> IMO.

>> The second problem is that follow mode uses code identical to my
>> second patch.

I just tested follow mode.  Its keymap doesn't work either and
unless anyone protests[1] it will not appear in beta13.  Besides not
working across frames it commits the mortal sin of defining keys on
C-c <alphabetic> keys.

> I don't know what follow mode is, and if it works.  Other minor modes
> seem to use the keymap here (not the symbol pointing to a keymap), and 
> my patch certainly does fix hide-ifdef-mode.

The primary advantage of autoloading the `add-minor-mode' call is to
make loading the minor-mode accessible by default by clicking on the
modeline.  I would like to see a solution where it can be autoloaded.

> I think you should apply my patch, and remove the ;;;###autoload,
> additionally.

If it can work to autoload the keymap, I'd prefer that as a solution.

Footnotes: 
[1]  *And* converts it to work correctly with multiple frames *and*
removes the *sinful* C-c alphabetic keybindings.  The latter
requirement is non-negotiable.

-- 
steve@calag.com baur
Unsolicited commercial e-mail will be billed at $250/message.

