From xemacs-m  Tue Jul  8 08:10:30 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id IAA01683
	for <xemacs-beta@xemacs.org>; Tue, 8 Jul 1997 08:10:28 -0500 (CDT)
Received: (from hniksic@localhost)
          by jagor.srce.hr (8.8.5/8.8.4)
	  id PAA01262; Tue, 8 Jul 1997 15:10:28 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: [PATCH] `log-message-ignore-regexps': Message labeling
References: <kigiuz3wmww.fsf@jagor.srce.hr> 	<QQcvjv09752.199706250049@crystal.WonderWorks.COM> 	<kigbu4uofrp.fsf@jagor.srce.hr> 	<QQcvmj23648.199706251719@crystal.WonderWorks.COM> 	<kigk9ji8tmh.fsf@jagor.srce.hr> 	<QQcvus16541.199706272335@crystal.WonderWorks.COM> 	<kig3eq3t0pq.fsf@jagor.srce.hr> <QQcvxf00524.199706281550@crystal.WonderWorks.COM> <kigzpsad7rr.fsf@jagor.srce.hr> <m2d8otwxab.fsf@altair.xemacs.org>
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 08 Jul 1997 15:10:28 +0200
In-Reply-To: Steven L Baur's message of "08 Jul 1997 05:20:12 -0700"
Message-ID: <kigzprxk7uj.fsf@jagor.srce.hr>
Lines: 131
X-Mailer: Gnus v5.4.59/XEmacs 20.3(beta11) - "Stockholm"

Steven L Baur <steve@xemacs.org> writes:

> (...) I want more lenient default behavior of messages entering
> *Message-Log*.

I think you are right.  Here is a patch that does it -- it leaves only 
three regexps in the list, and comments the rest out (so people who
want to have them can see what they look like).

BTW, I think these variables should be defcustoms.  If noone screams
against it, I'll put out a second patch.


1997-07-08  Hrvoje Niksic  <hniksic@srce.hr>

	* prim/simple.el (log-message-ignore-regexps): Reduced
 	significantly.

--- lisp/prim/simple.el.orig	Tue Jul  8 14:58:19 1997
+++ lisp/prim/simple.el	Tue Jul  8 15:04:54 1997
@@ -3214,57 +3214,70 @@
   "Maximum size of the \" *Message-Log*\" buffer.  See `log-message'.")
 (make-compatible-variable 'message-log-max 'log-message-max-size)
 
+;; We used to reject quite a lot of stuff here, but it was a bad idea,
+;; for two reasons:
+;;
+;; a) In most circumstances, you *want* to see the message in the log.
+;;    The explicitly non-loggable messages should be marked as such by
+;;    the issuer.  Gratuitous non-displaying of random regexps made
+;;    debugging harder, too (because various reasonable debugging
+;;    messages would get eaten).
+;;
+;; b) It slowed things down.  Yes, visibly.
+;;
+;; So, I left only a few of the really useless ones on this kill-list.
+;;
+;;                                            --hniksic
 (defvar log-message-ignore-regexps
   '(;; Often-seen messages
-    "^$"				; empty message
-    "^Mark set$"
-    "^\\(Beginning\\|End\\) of buffer$"
-    "^Quit$"
-    "^Killing [0-9]+ characters$"
+    "\\`\\'"				; empty message
+    ;;"^Mark set$"
+    ;;"^\\(Beginning\\|End\\) of buffer$"
+    ;;"^Quit$"
+    ;;"^Killing [0-9]+ characters$"
     ;; saving
-    "^Saving file .*\\.\\.\\.$"		; note: cannot ignore ^Wrote, because
+    ;;"^Saving file .*\\.\\.\\.$"		; note: cannot ignore ^Wrote, because
 					; it would kill off too much stuff.
-    "^(No changes need to be saved)$"
-    "^(No files need saving)$"
+    ;;"^(No changes need to be saved)$"
+    ;;"^(No files need saving)$"
     ;; undo, with the output of redo.el
-    "^Undo[!.]+$"
-    "^Redo[!.]+$"
+    "\\`Undo[!.]+\\'"
+    "\\`Redo[!.]+\\'"
     ;; M-x compile
-    "^Parsing error messages\\.\\.\\."
+    ;;"^Parsing error messages\\.\\.\\."
     ;; M-!
-    "^(Shell command completed with no output)"
+    ;;"^(Shell command completed with no output)"
     ;; font-lock
-    "^Fontifying"
+    "\\`Fontifying"
     ;; isearch
-    "^\\(Failing \\)?\\([Ww]rapped \\)?\\([Rr]egexp \\)?I-search\\( backward\\)?:"
-    "^Mark saved where search started$"
+    ;;"^\\(Failing \\)?\\([Ww]rapped \\)?\\([Rr]egexp \\)?I-search\\( backward\\)?:"
+    ;;"^Mark saved where search started$"
     ;; menus
-    "^Selecting menu item"
+    ;;"^Selecting menu item"
     ;; completions
-    "^Making completion list"
-    "^Matches "				; paren-matching message
+    ;;"^Making completion list"
+    ;;"^Matches "				; paren-matching message
     ;; help
-    "^Type .* to \\(remove help\\|restore the other\\) window."
-    "^M-x .* (bound to key"		; teach-extended-commands
+    ;;"^Type .* to \\(remove help\\|restore the other\\) window."
     ;; VM
-    "^\\(Parsing messages\\|Reading attributes\\|Generating summary\\|Building threads\\|Converting\\)\\.\\.\\. [0-9]+$"
-    "^End of message"			; + Gnus
+    ;;"^\\(Parsing messages\\|Reading attributes\\|Generating summary\\|Building threads\\|Converting\\)\\.\\.\\. [0-9]+$"
+    ;;"^End of message"			; + Gnus
     ;; Gnus
-    "^No news is no news$"
-    "^No more\\( unread\\)? newsgroups$"
-    "^Opening [^ ]+ server\\.\\.\\."
-    "^[^:]+: Reading incoming mail"
-    "^Getting mail from "
-    "^\\(Generating Summary\\|Sorting threads\\|Making sparse threads\\|Scoring\\|Checking new news\\|Expiring articles\\|Sending\\)\\.\\.\\."
-    "^\\(Fetching headers for\\|Retrieving newsgroup\\|Reading active file\\)"
-    "^No more\\( unread\\)? articles"
-    "^Deleting article "
+    ;;"^No news is no news$"
+    ;;"^No more\\( unread\\)? newsgroups$"
+    ;;"^Opening [^ ]+ server\\.\\.\\."
+    ;;"^[^:]+: Reading incoming mail"
+    ;;"^Getting mail from "
+    ;;"^\\(Generating Summary\\|Sorting threads\\|Making sparse threads\\|Scoring\\|Checking new news\\|Expiring articles\\|Sending\\)\\.\\.\\."
+    ;;"^\\(Fetching headers for\\|Retrieving newsgroup\\|Reading active file\\)"
+    ;;"^No more\\( unread\\)? articles"
+    ;;"^Deleting article "
     ;; W3
-    "^Parsed [0-9]+ of [0-9]+ ([0-9]+%)"
+    ;;"^Parsed [0-9]+ of [0-9]+ ([0-9]+%)"
     ;; outl-mouse
-    "^Adding glyphs\\.\\.\\."
+    ;;"^Adding glyphs\\.\\.\\."
     ;; bbdb
-    "^->"
+    ;;"^->"
     )
   "List of regular expressions matching messages which shouldn't be logged.
 See `log-message'.  


-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Speak softly and carry a +6 two-handed sword.

