From xemacs-m  Mon Jan  6 22:07:57 1997
Received: from venus.Sun.COM (venus.Sun.COM [192.9.25.5])
          by xemacs.cs.uiuc.edu (8.8.4/8.8.4) with SMTP
	  id WAA02486 for <xemacs-beta@xemacs.org>; Mon, 6 Jan 1997 22:07:56 -0600 (CST)
Received: from Eng.Sun.COM ([129.146.1.25]) by venus.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id UAA23400; Mon, 6 Jan 1997 20:07:26 -0800
Received: from kindra.eng.sun.com by Eng.Sun.COM (SMI-8.6/SMI-5.3)
	id UAA02182; Mon, 6 Jan 1997 20:07:23 -0800
Received: from xemacs.eng.sun.com by kindra.eng.sun.com (SMI-8.6/SMI-SVR4)
	id UAA04180; Mon, 6 Jan 1997 20:07:21 -0800
Received: by xemacs.eng.sun.com (SMI-8.6/SMI-SVR4)
	id UAA12927; Mon, 6 Jan 1997 20:07:20 -0800
Date: Mon, 6 Jan 1997 20:07:20 -0800
Message-Id: <199701070407.UAA12927@xemacs.eng.sun.com>
From: Martin Buchholz <mrb@Eng.Sun.COM>
To: jmiller@bayserve.net, MORIOKA Tomohiko <morioka@jaist.ac.jp>,
        Steven L Baur <steve@miranova.com>
Cc: xemacs-beta@xemacs.org, tm-en@chamonix.jaist.ac.jp
Subject: Re: patch for tm* file install
In-Reply-To: <199701070155.UAA00271@beavis.bayserve.net>
References: <Pine.SUN.3.95.970105154442.1638C-100000@bay1.bayserve.net>
	<u9rajz0xhh.fsf@chekov.ctd.comsat.com>
	<199701070155.UAA00271@beavis.bayserve.net>
Reply-To: Martin Buchholz <mrb@Eng.Sun.COM>
Mime-Version: 1.0 (generated by tm-edit 7.100)
Content-Type: multipart/mixed;
 boundary="Multipart_Mon_Jan__6_20:07:18_1997-1"
Content-Transfer-Encoding: 7bit

--Multipart_Mon_Jan__6_20:07:18_1997-1
Content-Type: text/plain; charset=US-ASCII

>>>>> "jm" == jmiller  <jmiller@bayserve.net> writes:

>>>>> "NB" == Neal Becker <neal@ctd.comsat.com> writes:
NB> I don't think tmdecode and friends should go in bindir.  There are
NB> never intended to be directly invoked by users.  They should go to the
NB> same place as movemail, for example.

jm> This seems more correct.  I originally didn't put them there, because I
jm> think when I originally installed tm for testing a long time ago, it got
jm> put in /usr/local/bin.

jm> So I tried moving them over to the same dir as movemail.  Things work
jm> except tmdecode wasn't found.  So I moved it back to bindir and things
jm> work.

jm> updated patch included:

jm's patch is probably not correct.  The tm*scripts should go into
exec-directory, since the user doesn't need to call them directly.

Steven: There is already code in 20.0's lib-src/Makefile.in to install
TM scripts and executables.  I personally would have eschewed
integrating tm into 19.15, but since you did it, you will have to
apply similar changes to lib-src/Makefile.in in 19.15 as I did to
20.0.  (Hint: search for tm and mmencode in 20.0's lib-src/Makefile.in).

The way I integrated TM into 20.0 is also broken.  Although tm* and
mmencode get installed into exec-directory, when tm-file call
tmdecode, tmdecode is NOT FOUND, and so tm-file fails.
This is because exec-directory is unlikely to be on the PATH.  tm-file
can find exec-directory via `dirname $0`, so the following patch seems
to be in order.

Tomohiko:  please apply the following patch (or suggest a better
solution):

--[[text/plain]
--- /home/mrb/x/w/editor/lib-src/tm-au	Sun Dec 29 21:27:07 1996
+++ /home/mrb/x/tm/editor/lib-src/tm-au	Mon Jan  6 19:37:36 1997
@@ -4,4 +4,6 @@
 #
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
 	TM_TMP_DIR=/tmp
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tm-file /home/mrb/x/tm/editor/lib-src/tm-file
--- /home/mrb/x/w/editor/lib-src/tm-file	Wed Sep 25 11:50:26 1996
+++ /home/mrb/x/tm/editor/lib-src/tm-file	Mon Jan  6 19:37:22 1997
@@ -4,4 +4,6 @@
 #
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
 	TM_TMP_DIR=/tmp
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tm-html /home/mrb/x/tm/editor/lib-src/tm-html
--- /home/mrb/x/w/editor/lib-src/tm-html	Wed Sep 25 11:50:12 1996
+++ /home/mrb/x/tm/editor/lib-src/tm-html	Mon Jan  6 19:37:13 1997
@@ -4,4 +4,6 @@
 #
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
     TM_TMP_DIR=/tmp
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tm-image /home/mrb/x/tm/editor/lib-src/tm-image
--- /home/mrb/x/w/editor/lib-src/tm-image	Wed Sep 25 11:50:05 1996
+++ /home/mrb/x/tm/editor/lib-src/tm-image	Mon Jan  6 19:34:39 1997
@@ -20,4 +20,6 @@
 # Boston, MA 02111-1307, USA.
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
 	TM_TMP_DIR=/tmp
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tm-mpeg /home/mrb/x/tm/editor/lib-src/tm-mpeg
--- /home/mrb/x/w/editor/lib-src/tm-mpeg	Wed Sep 25 11:49:58 1996
+++ /home/mrb/x/tm/editor/lib-src/tm-mpeg	Mon Jan  6 19:33:21 1997
@@ -20,4 +20,6 @@
 # Boston, MA 02111-1307, USA.
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
 	TM_TMP_DIR=/tmp
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tm-plain /home/mrb/x/tm/editor/lib-src/tm-plain
--- /home/mrb/x/w/editor/lib-src/tm-plain	Mon Dec 18 03:37:17 1995
+++ /home/mrb/x/tm/editor/lib-src/tm-plain	Mon Jan  6 19:32:36 1997
@@ -4,4 +4,6 @@
 #
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
 	TM_TMP_DIR=/tmp
@@ -28,3 +30,3 @@
 	tmdecode "$3" "$1" /dev/stdout | lpr
 	;;
-esac
\ No newline at end of file
+esac
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tm-ps /home/mrb/x/tm/editor/lib-src/tm-ps
--- /home/mrb/x/w/editor/lib-src/tm-ps	Wed Sep 25 11:49:43 1996
+++ /home/mrb/x/tm/editor/lib-src/tm-ps	Mon Jan  6 19:32:15 1997
@@ -20,4 +20,6 @@
 # Boston, MA 02111-1307, USA.
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 if [ "$TM_TMP_DIR" = "" ]; then
 	TM_TMP_DIR=/tmp
diff -U2 --recursive /home/mrb/x/w/editor/lib-src/tmdecode /home/mrb/x/tm/editor/lib-src/tmdecode
--- /home/mrb/x/w/editor/lib-src/tmdecode	Wed Sep 25 11:49:34 1996
+++ /home/mrb/x/tm/editor/lib-src/tmdecode	Mon Jan  6 19:35:29 1997
@@ -20,4 +20,6 @@
 # Boston, MA 02111-1307, USA.
 
+PATH=${PATH:-/usr/bin:/bin}:`dirname $0 2>/dev/null`; export PATH
+
 trap 'rm -f $2' 0 1 2 3 13 15
 

--Multipart_Mon_Jan__6_20:07:18_1997-1
Content-Type: text/plain; charset=US-ASCII


(Don't apply this)

jm> --- lib-src/Makefile.in.in.orig Sun Jan  5 12:47:21 1997
jm> +++ lib-src/Makefile.in.in      Mon Jan  6 20:50:31 1997
jm> @@ -100,13 +100,13 @@
jm>  /* Things that a user might actually run,
jm>     which should be installed in bindir. */
jm>  INSTALLABLES = etags ctags emacsclient b2m gnuclient gnuattach gnudoit
jm> -INSTALLABLE_SCRIPTS = rcs-checkin
jm> +INSTALLABLE_SCRIPTS = rcs-checkin tmdecode
 
jm>  /* Things that Emacs runs internally, or during the build process,
jm>     which should not be installed in bindir. */
jm>  UTILITIES= make-path wakeup profile make-docfile digest-doc \
jm>         sorted-doc movemail cvtmail fakemail yow emacsserver hexl \
jm> -       gnuserv
jm> +       gnuserv tm-au tm-file tm-html tm-image tm-mpeg tm-plain tm-ps
 
jm>  /* Like UTILITIES, but they're not system-dependent, and should not be
jm>     deleted by the distclean target. */


Martin
--Multipart_Mon_Jan__6_20:07:18_1997-1--

