K 10
svn:author
V 6
kondou
K 8
svn:date
V 27
1998-05-18T23:39:52.000000Z
K 7
svn:log
V 1484
innfeed/connection.c:
innfeed/innlistener.c:
	- From: Per Hedeland <per@erix.ericsson.se>
	- When using funnel file input to innfeed, and you have a system
	  crash, there seems to be a large probability that you end up with
	  a bunch of NUL characters in the funnel file. Innfeed deals very
	  badly with this, inasmuch as it will stop sending anything out and
	  just keep reading the funnel file into memory forever. The problem
	  is also present when using a channel feed of course, but probably
	  far less likely to occur.

	  The patches below deal with this by making innfeed exit after
	  logging an error message if there are any NULs in the input - they
	  have been tested as far as possible by both myself and John Line
	  - we've both been hit twice recently by the behaviour described
	  above. They were originally against innfeed-0.10.1.7 which we're
	  running, but have been converted to the version in
	  inn-1998-05-11_04-00, which seems identical in this respect.

	- There are also a couple of more-or-less unrelated changes in the
	  patch:

	- Innfeed used memcpy() for (potentially) overlapping copies, which
	  is a no-no of course - I guess this hasn't caused problems because
	  most implementations probably manage it in the "downward"
	  direction and/or the copy in practice rarely/never really is
	  overlapping.

	- I think innfeed packing up and going home warrants a LOG_CRIT
	  (meaning that if you run innwatch it will send you mail about it).

END
