# Meeting 20.03.2024

## gana

we can not delete the gana submodul from the donau. We use the gana from the exchange for the error codes, but not for the signature codes.

how to update gana:

1. update gnu-taler-error-codes/registry.rec and gnu-taler-error-codes/taler_error_codes.rst (Donau error code (ec) 8600 - 8700.

2. update gana in exchange
   
   ```bash
   cd contrib/gana
   git pull
   checkout master
   git add . # gana-bumb commit and push
   # install exchange
   ```

## keys

the keys route has two main tasks: 

1. act as route and return requested keys

2. sign for other routes! -> Other routes do not have access to the private keys!
- We do not sort the keys therefore we don't need a heap. We can directly iterate over the donation unit map. 
- krd_array can be deleted. Its already hashed ???
- Put KeysResponseData into the main datastructure. It contains the etag (year in our case and version)

## issue receipts

We must ensure that the update the receipts to date of a charity and the receipt request are both saved in the database or thrown away. To do this, we need transactions. Its best practice to try a database insert 3 times to reduce the risk of serialization errors (if it has not worked after 3 times, the error is probably somewhere else).

## uncrystify

install uncrystify. If so you cant upload bad formated code. With uncrystify you can automatically format the code.
