From xemacs-m  Thu Jun 19 21:21:13 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id VAA11334
	for <xemacs-beta@xemacs.org>; Thu, 19 Jun 1997 21:21:12 -0500 (CDT)
Received: (from hniksic@localhost)
          by jagor.srce.hr (8.8.5/8.8.4)
	  id EAA12778; Fri, 20 Jun 1997 04:21:10 +0200 (MET DST)
To: karlheg@inetarena.com (Karl M. Hegbloom)
Cc: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: [patch] font-lock.el
References: <87lo46iybz.fsf@bittersweet.inetarena.com> <kig4tau1nis.fsf@jagor.srce.hr> <87u3iuowc6.fsf@bittersweet.inetarena.com>
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 20 Jun 1997 04:21:10 +0200
In-Reply-To: karlheg@inetarena.com's message of "19 Jun 1997 19:13:29 -0700"
Message-ID: <kig3eqehv55.fsf@jagor.srce.hr>
Lines: 47
X-Mailer: Gnus v5.4.59/XEmacs 20.3(beta7) - "Oslo"

karlheg@inetarena.com (Karl M. Hegbloom) writes:

> It needs work, maybe...

If it needs work, it is certainly not good enough for inclusion to
XEmacs.  We have enough work with the packages already in.

Unless you volunteer to do the work prior to the inclusion, of course!

> You're right, it's not, I looked there too, when I was trying to
> find it for making the lisp keywords patch I sent.  That seems odd,
> since it is what was used to generate the font-lock keywords
> regexpressions; It's clearly shown in the comments.  Hmmm.
> Intentional oversight?  Trying to get us to look over the archive?

No, I'd say the package is useless to Emacs users, but useful to
developers.  As it is useful only to the developers who want to build
enormous regexps, RMS decided (I guess so) not to included.  Maybe he
even wanted to prevent the flood of terrible regexps, ensuing from the 
overuse of this package! ;-)

Simon could probably shed more light to this.

> When you all look this over, could someone let me know what is the
> purpose of the let with the while inside it beginning on line 130???
> I cannot see any reason for it to be there.  I don't think it does
> anything.

Of course it does -- it uniquifies the list of strings, destructively.
The comment even says so!

> 	 (strings (let ((l strings))	; Paranoia---make strings unique!
> 		    (while l (setq l (setcdr l (delete (car l) (cdr l)))))
> 		    (sort strings 'string-lessp)))

(let* ((strings '("a" "c" "b" "d" "b" "a"))
       (l strings))
  (while l (setq l (setcdr l (delete (car l) (cdr l)))))
  strings)

  => ("a" "c" "b" "d")

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
"Silence!" cries Freydag. "I did not call thee in for a consultation!" 
"They are my innards! I will not have them misread by a poseur!"

