From xemacs-m  Wed Jun 18 13:53:09 1997
Received: from steadfast.teradyne.com (steadfast.teradyne.com [131.101.1.200])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id NAA26634
	for <xemacs-beta@xemacs.org>; Wed, 18 Jun 1997 13:53:08 -0500 (CDT)
Received: from engine.ecf.teradyne.com (engine.ecf.teradyne.com [131.101.192.6]) by steadfast.teradyne.com (8.7.1/8.7.1) with ESMTP id OAA05989 for <xemacs-beta@xemacs.org>; Wed, 18 Jun 1997 14:57:09 -0400 (EDT)
Received: from midnight.eng.ecf.teradyne.com (midnight.ecf.teradyne.com [131.101.192.49]) by engine.ecf.teradyne.com (8.7.1/8.7.1) with SMTP id UAA23335; Wed, 18 Jun 1997 20:52:35 +0200 (MET DST)
Received: by midnight.eng.ecf.teradyne.com (SMI-8.6/SMI-SVR4)
	id UAA05670; Wed, 18 Jun 1997 20:52:35 +0200
To: xemacs-beta@xemacs.org
Subject: Re: arc-mode warnings
References: <rxsafko5hni.fsf@midnight.ecf.teradyne.com> <m2en9z6d1u.fsf@altair.xemacs.org>
X-Face: 4[iHdXiTu\V3u[~\I)<f9HC);%~nG8`oUqv#uzvs6=\V{AjN6Sn
 c/qi;YLwRmEbt8Y*=j5n(urqY@chPh@J'D"QlqD!C8>*}#kYF[-tYl3VZga/HSOP|K,{L
 Rtu@f0y/=O&Cu}\:~d|P$JON?pn?j,&CnPb1z#/TL9bkAJwyol&a:SvYj-VYbM=Dtxhk9
 =w|R6U3_;SH&B<Mfy6Q%#
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
From: Adrian Aichner <aichner@ecf.teradyne.com>
Date: 18 Jun 1997 20:52:33 +0200
In-Reply-To: Steven L Baur's message of "18 Jun 1997 10:22:53 -0700"
Message-ID: <rxsafkng2vi.fsf@midnight.ecf.teradyne.com>
Lines: 96
X-Mailer: Gnus v5.4.56/XEmacs 20.3(beta7) - "Oslo"

>>>>> "sb" == Steven L Baur <steve@xemacs.org> writes:

    sb> Adrian Aichner <aichner@ecf.teradyne.com> writes:
    >> Entering arc-mode on a zip attachment extracted from an E-mail with
    >> Gnus under emacs-version "20.3 \"Oslo\" XEmacs Lucid (beta7)" I got
    >> the following warnings on XEmacs's STDERR.

    sb> Please try it again with this patch.  The Ebola notices you got were
    sb> the real thing.

Steven,

I applied the patch,
byte-compiled arc-mode.el,
started a fresh xemacs,
Entered the zip file from yesterday in /tmp via dired,
and got the following warnings (these are all I got):

aichner@midnight(571) Comparison between integer and character is constant nil (?\^C and 0)
   [archive-zip-summarize, archive-summarize, archive-mode, set-auto-mode, byte-code, normal-mode, after-find-file, find-file-noselect, default-dir-real-find-file, find-file, dired-find-file, call-interactively]
Comparison between integer and character is constant nil (?\^C and 2)
   [archive-zip-summarize, archive-summarize, archive-mode, set-auto-mode, byte-code, normal-mode, after-find-file, find-file-noselect, default-dir-real-find-file, find-file, dired-find-file, call-interactively]
Comparison between integer and character is constant nil (?\^C and 4)
   [archive-zip-summarize, archive-summarize, archive-mode, set-auto-mode, byte-code, normal-mode, after-find-file, find-file-noselect, default-dir-real-find-file, find-file, dired-find-file, call-interactively]
Comparison between integer and character is constant nil (?\^C and 5)
   [archive-zip-summarize, archive-summarize, archive-mode, set-auto-mode, byte-code, normal-mode, after-find-file, find-file-noselect, default-dir-real-find-file, find-file, dired-find-file, call-interactively]
Comparison between integer and character is constant nil (?\^C and 9)
   [archive-zip-summarize, archive-summarize, archive-mode, set-auto-mode, byte-code, normal-mode, after-find-file, find-file-noselect, default-dir-real-find-file, find-file, dired-find-file, call-interactively]

Regards,

Adrian

    sb> Index: lisp/modes/arc-mode.el
    sb> ===================================================================
    sb> RCS file: /usr/local/xemacs/xemacs-20.0/lisp/modes/arc-mode.el,v
    sb> retrieving revision 1.2
    sb> diff -u -r1.2 arc-mode.el
    sb> --- arc-mode.el	1997/06/14 20:31:08	1.2
    sb> +++ arc-mode.el	1997/06/18 17:17:45
    sb> @@ -1123,7 +1123,7 @@
    sb>          files
    sb>  	visual)
    sb>      (while (and (< (+ p 29) (point-max))
    sb> -		(= (char-after p) ?\C-z)
    sb> +		(eq (char-after p) ?\C-z)
    sb>  		(> (char-after (1+ p)) 0))
    sb>        (let* ((namefld (buffer-substring (+ p 2) (+ p 2 13)))
    sb>  	     (fnlen   (or (string-match "\0" namefld) 13))
    sb> @@ -1198,10 +1198,10 @@
    sb>               (ifnname (if fiddle (downcase efnname) efnname))
    sb>  	     (p2      (+ p 22 fnlen))
    sb>  	     (creator (if (>= (- hsize fnlen) 24) (char-after (+ p2 2)) 0))
    sb> -	     (mode    (if (= creator ?U) (archive-l-e (+ p2 8) 2) ?\666))
    sb> +	     (mode    (if (eq creator ?U) (archive-l-e (+ p2 8) 2) ?\666))
    sb>  	     (modestr (if mode (archive-int-to-mode mode) "??????????"))
    sb> -	     (uid     (if (= creator ?U) (archive-l-e (+ p2 10) 2)))
    sb> -	     (gid     (if (= creator ?U) (archive-l-e (+ p2 12) 2)))
    sb> +	     (uid     (if (eq creator ?U) (archive-l-e (+ p2 10) 2)))
    sb> +	     (gid     (if (eq creator ?U) (archive-l-e (+ p2 12) 2)))
    sb>  	     (text    (if archive-alternate-display
    sb>  			  (format "  %8d  %5S  %5S  %s"
    sb>  				  ucsize
    sb> @@ -1338,9 +1338,10 @@
    sb>               (efnname (buffer-substring (+ p 46) (+ p 46 fnlen)))
    sb>  	     (isdir   (and (= ucsize 0)
    sb>  			   (string= (file-name-nondirectory efnname) "")))
    sb> -	     (mode    (cond ((memq creator '(2 3)) ; Unix + VMS
    sb> +	     (mode    (cond ((memq (char-int creator) '(2 3)) ; Unix + VMS
    sb>  			     (archive-l-e (+ p 40) 2))
    sb> -			    ((memq creator '(0 5 6 7 10 11)) ; Dos etc.
    sb> +			    ((memq (char-int creator)
    sb> +				   '(0 5 6 7 10 11)) ; Dos etc.
    sb>  			     (logior ?\444
    sb>  				     (if isdir (logior 16384 ?\111) 0)
    sb>  				     (if (zerop
    sb> @@ -1406,11 +1407,11 @@
    sb>  	       (oldmode (aref fil 3))
    sb>  	       (newval  (archive-calc-mode oldmode newmode t))
    sb>  	       buffer-read-only)
    sb> -	  (cond ((memq creator '(2 3)) ; Unix + VMS
    sb> +	  (cond ((memq (char-int creator) '(2 3)) ; Unix + VMS
    sb>  		 (goto-char (+ p 40))
    sb>  		 (delete-char 2)
    sb>  		 (insert (logand newval 255) (lsh newval -8)))
    sb> -		((memq creator '(0 5 6 7 10 11)) ; Dos etc.
    sb> +		((memq (char-int creator) '(0 5 6 7 10 11)) ; Dos etc.
    sb>  		 (goto-char (+ p 38))
    sb>  		 (insert (logior (logand (char-after (point)) 254)
    sb>  				 (logand (logxor 1 (lsh newval -7)) 1)))

    sb> -- 
    sb> steve@calag.com baur
    sb> Unsolicited commercial e-mail will be billed at $250/message.


