From xemacs-m  Sun Jan  5 19:52:05 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
          by xemacs.cs.uiuc.edu (8.8.4/8.8.4) with ESMTP
	  id TAA18013 for <xemacs-beta@xemacs.org>; Sun, 5 Jan 1997 19:52:04 -0600 (CST)
Received: (from steve@localhost)
          by altair.xemacs.org (8.8.4/8.8.4)
	  id SAA15861; Sun, 5 Jan 1997 18:02:17 -0800
Sender: steve@xemacs.org
To: xemacs-beta@xemacs.org
Subject: Re: 20.0-b34 SIGSEGV's when run -nw
References: <yvia7mlr6dd1.fsf@atreides.mindspring.com> <m2iv5bu080.fsf@altair.xemacs.org> <yviaenfztzj3.fsf@atreides.mindspring.com>
X-Url: http://www.miranova.com/%7Esteve/
Mail-Copies-To: never
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@miranova.com>
In-Reply-To: Sudish Joseph's message of 05 Jan 1997 19:31:28 -0500
Mime-Version: 1.0 (generated by tm-edit 7.100)
Content-Type: text/plain; charset=US-ASCII
Date: 05 Jan 1997 18:02:15 -0800
Message-ID: <m27mlrtvbs.fsf@altair.xemacs.org>
Lines: 115
X-Mailer: Red Gnus v0.72/XEmacs 20.0

>>>>> "Sudish" == Sudish Joseph <sudish@mindspring.com> writes:

Sudish> Steven L Baur writes:

Sudish> Program received signal SIGSEGV, Segmentation fault.
Sudish> 0x806da15 in stream_canonicalize_console_connection (connection={s = {
Sudish> type_mark = 1, val = 0}, gu = {type = Lisp_Record, markbit = 0,
Sudish> val = 0}, i = 1, v = 0x1, cv = 0x1}, errb=-1073748016)
Sudish> at /home/sj/src/xemacs/src/console-stream.c:147
Sudish> 147             return Qunbound;

sb> This code was just changed.  What options are you giving configure?
sb> I've never seen the `union type' message before.

Sudish> #!/bin/sh
Sudish> ../configure  --verbose --with-mule=no --with-gcc --with-gnu-make 
Sudish>   --cflags='-g -O6 -malign-loops=2 -malign-jumps=2 -malign-functions=2' 
Sudish>   --dynamic=yes --const-is-losing=no --with-xpm --with-toolbars=no --with-gif 
Sudish>   --with-jpeg --with-xim=xlib --with-dialogs=athena --debug 
Sudish>   --error-checking=none --use-union-type --rel-alloc --use-system-malloc 
Sudish>   --with-database=berkdb,gnudbm 2>&1 | tee runconfig.out

Sudish> (I changed to -O6 _after_ generating that backtrace.  Yes, I'm
Sudish> aware that a lot of those options will be autodetected, I just
Sudish> like having stuff up front.)

Sudish> I've been using --use-union-type for a while (gdb behaves better).

Oops.  Here's the fix.  A similar patch to 19.15 needs to be made if
you're using --use-union-type on that.

Index: toolbar.c
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/src/toolbar.c,v
retrieving revision 1.2
diff -u -r1.2 toolbar.c
--- toolbar.c	1997/01/04 23:05:32	1.2
+++ toolbar.c	1997/01/06 01:37:52
@@ -1675,18 +1675,18 @@
   elt = list1 (Fcons (list1 (Qtty), Qzero));
 #endif
 #ifdef HAVE_X_WINDOWS
-  if (elt != Qnil)
+  if (!EQ(elt, Qnil))
     elt = Fcons (Fcons (list1 (Qx), make_int (DEFAULT_TOOLBAR_HEIGHT)), elt);
   else
     elt = list1 (Fcons (list1 (Qx), make_int (DEFAULT_TOOLBAR_HEIGHT)));
 #endif
 #ifdef HAVE_NEXTSTEP
-  if (elt != Qnil)
+  if (!EQ(elt, Qnil))
     elt = Fcons (Fcons (list1 (Qns), make_int (DEFAULT_TOOLBAR_HEIGHT)), elt);
   else
     elt = list1 (Fcons (list1 (Qns), make_int (DEFAULT_TOOLBAR_HEIGHT)));
 #endif
-  if (elt != Qnil)
+  if (!EQ(elt, Qnil))
     set_specifier_fallback (Vdefault_toolbar_height, elt);
 
   elt = Qnil;
@@ -1694,18 +1694,18 @@
   elt = list1 (Fcons (list1 (Qtty), Qzero));
 #endif
 #ifdef HAVE_X_WINDOWS
-  if (elt != Qnil)
+  if (!EQ(elt, Qnil))
     elt = Fcons (Fcons (list1 (Qx), make_int (DEFAULT_TOOLBAR_WIDTH)), elt);
   else
     elt = list1 (Fcons (list1 (Qx), make_int (DEFAULT_TOOLBAR_WIDTH)));
 #endif
 #ifdef HAVE_NEXTSTEP
-  if (elt != Qnil)
+  if (!EQ(elt, Qnil))
     elt = Fcons (Fcons (list1 (Qns), make_int (DEFAULT_TOOLBAR_WIDTH)), elt);
   else
     elt = list1 (Fcons (list1 (Qns), make_int (DEFAULT_TOOLBAR_WIDTH)));
 #endif
-  if (elt != Qnil)
+  if (!EQ(elt, Qnil))
     set_specifier_fallback (Vdefault_toolbar_width, elt);
 
   set_specifier_fallback (Vtoolbar_size[TOP_TOOLBAR], Vdefault_toolbar_height);


Index: console-tty.c
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/src/console-tty.c,v
retrieving revision 1.2
diff -u -r1.2 console-tty.c
--- console-tty.c	1997/01/04 23:05:30	1.2
+++ console-tty.c	1997/01/06 01:51:38
@@ -206,6 +206,8 @@
   return CONSOLE_TTY_DATA (decode_tty_console (console))->terminal_type;
 }
 
+extern Lisp_Object stream_semi_canonicalize_console_connection(Lisp_Object,
+							       Error_behavior);
 Lisp_Object
 tty_semi_canonicalize_console_connection (Lisp_Object connection,
 					  Error_behavior errb)
@@ -213,6 +215,8 @@
   return stream_semi_canonicalize_console_connection (connection, errb);
 }
 
+extern Lisp_Object stream_canonicalize_console_connection(Lisp_Object,
+							  Error_behavior);
 Lisp_Object
 tty_canonicalize_console_connection (Lisp_Object connection,
 				     Error_behavior errb)

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be billed at $250/message.
"That Bill Clinton.  He probably doesn't know how to log on to the
Internet."  -- Rush Limbaugh, noted Computer Expert

