From xemacs-m  Tue Jun 10 19:16:17 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id TAA05617
	for <xemacs-beta@xemacs.org>; Tue, 10 Jun 1997 19:16:12 -0500 (CDT)
Received: (from steve@localhost)
	by altair.xemacs.org (8.8.5/8.8.5) id RAA06659;
	Tue, 10 Jun 1997 17:16:23 -0700
Mail-Copies-To: never
To: xemacs-beta@xemacs.org
Subject: Re: beta 5 gnus wierdness
References: <bcienaa9fqm.fsf@corp.Sun.COM>
X-Url: http://www.miranova.com/%7Esteve/
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@xemacs.org>
In-Reply-To: Gary.Foster@Corp.Sun.COM's message of "10 Jun 1997 16:53:53 -0700"
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
Date: 10 Jun 1997 17:16:23 -0700
Message-ID: <m2206aouy0.fsf@altair.xemacs.org>
Lines: 190
X-Mailer: Gnus v5.4.56/XEmacs 20.3(beta6) - "Moscow"

Gary D Foster <Gary.Foster@Corp.Sun.COM> writes:

> I get the following when starting up gnus in beta 5:
> (I get a bunch of these dumped to the tty I launched XEmacs from)

> Comparison between integer and character is constant nil (0 and ?5)
>    [nntp-request-group, byte-code, gnus-activate-group, gnus-get-unread-articles, gnus-setup-news, byte-code, gnus-1, gnus]

Ebola!  Ebola!  Ebola!

Here is a copy of a patch I just sent Lars:
Index: lisp/gnus/nntp.el
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/lisp/gnus/nntp.el,v
retrieving revision 1.8
diff -u -r1.8 nntp.el
--- nntp.el	1997/05/03 00:26:17	1.8
+++ nntp.el	1997/06/10 23:10:56
@@ -189,7 +189,7 @@
   (save-excursion
     (set-buffer (process-buffer process))
     (goto-char (point-min))
-    (while (or (not (memq (following-char) '(?2 ?3 ?4 ?5)))
+    (while (or (not (memq (char-after) '(?2 ?3 ?4 ?5)))
 	       (looking-at "480"))
       (when (looking-at "480")
 	(erase-buffer)


There's (a lot) more Ebola lurking in the mail code.

Index: lisp/utils/mail-extr.el
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/lisp/utils/mail-extr.el,v
retrieving revision 1.4
diff -u -r1.4 mail-extr.el
--- mail-extr.el	1997/03/22 06:02:47	1.4
+++ mail-extr.el	1997/06/11 00:00:53
@@ -1530,16 +1530,16 @@
 	       (looking-at mail-extr-full-name-suffix-pattern))
 	  (mail-extr-skip-whitespace-backward)
 	  (setq suffix-flag (point))
-	  (if (eq ?, (following-char))
+	  (if (eq ?, (char-after))
 	      (forward-char 1)
 	    (insert ?,))
 	  ;; Enforce at least one space after comma
-	  (or (eq ?\  (following-char))
+	  (or (eq ?\  (char-after))
 	      (insert ?\ ))
 	  (mail-extr-skip-whitespace-forward)
-	  (cond ((memq (following-char) '(?j ?J ?s ?S))
+	  (cond ((memq (char-after) '(?j ?J ?s ?S))
 		 (capitalize-word 1)
-		 (if (eq (following-char) ?.)
+		 (if (eq (char-after) ?.)
 		     (forward-char 1)
 		   (insert ?.)))
 		(t
@@ -1554,26 +1554,26 @@
 	  (setq begin-again-flag t))
 	 
 	 ;; Check for initial last name followed by comma
-	 ((and (eq ?, (following-char))
+	 ((and (eq ?, (char-after))
 	       (eq word-count 1))
 	  (forward-char 1)
 	  (setq last-name-comma-flag t)
-	  (or (eq ?\  (following-char))
+	  (or (eq ?\  (char-after))
 	      (insert ?\ )))
-	 
+
 	 ;; Stop before trailing comma-separated comment
 	 ;; THIS CASE MUST BE AFTER THE PRECEDING CASES.
 	 ;; *** This case is redundant???
-	 ;;((eq ?, (following-char))
+	 ;;((eq ?, (char-after))
 	 ;; (setq name-done-flag t))
 	 
 	 ;; Delete parenthesized/quoted comment/nickname
-	 ((memq (following-char) '(?\( ?\{ ?\[ ?\" ?\' ?\`))
+	 ((memq (char-after) '(?\( ?\{ ?\[ ?\" ?\' ?\`))
 	  (setq cbeg (point))
 	  (set-syntax-table mail-extr-address-text-comment-syntax-table)
-	  (cond ((memq (following-char) '(?\' ?\`))
+	  (cond ((memq (char-after) '(?\' ?\`))
 		 (or (search-forward "'" nil t
-				     (if (eq ?\' (following-char)) 2 1))
+				     (if (eq ?\' (char-after)) 2 1))
 		     (mail-extr-delete-char 1)))
 		(t
 		 (or (mail-extr-safe-move-sexp 1)
@@ -1601,7 +1601,7 @@
 	 
 	 ;; Handle & substitution
 	 ((and (or (bobp)
-		   (eq ?\  (preceding-char)))
+		   (eq ?\  (char-before)))
 	       (looking-at "&\\( \\|\\'\\)"))
 	  (mail-extr-delete-char 1)
 	  (capitalize-region
@@ -1616,7 +1616,7 @@
 	 ;; Handle *Stupid* VMS date stamps
 	 ((looking-at mail-extr-stupid-vms-date-stamp-pattern)
 	  (replace-match "" t))
-	 
+
 	 ;; Handle Chinese characters.
 	 ((looking-at mail-extr-hz-embedded-gb-encoded-chinese-pattern)
 	  (goto-char (match-end 0))
@@ -1658,28 +1658,28 @@
 	 
 	 ;; Fixup initials
 	 ((looking-at mail-extr-initial-pattern)
-	  (or (eq (following-char) (upcase (following-char)))
+	  (or (eq (char-after) (upcase (char-after)))
 	      (setq lower-case-flag t))
 	  (forward-char 1)
-	  (if (eq ?. (following-char))
-	      (forward-char 1)
+	  (if (eq ?. (char-after))
+	      (char-after 1)
 	    (insert ?.))
-	  (or (eq ?\  (following-char))
+	  (or (eq ?\  (char-after))
 	      (insert ?\ ))
 	  (setq word-found-flag t))
-	 
+
 	 ;; Handle BITNET LISTSERV list names.
 	 ((and (eq word-count 0)
 	       (looking-at mail-extr-listserv-list-name-pattern))
 	  (narrow-to-region (match-beginning 1) (match-end 1))
 	  (setq word-found-flag t)
 	  (setq name-done-flag t))
-	 
+
 	 ;; Regular name words
 	 ((looking-at mail-extr-name-pattern)
 	  (setq name-beg (point))
 	  (setq name-end (match-end 0))
-	  
+
 	  ;; Certain words will be dropped if they are at the end.
 	  (and (>= word-count 2)
 	       (not lower-case-flag)
@@ -1746,7 +1746,7 @@
 	     (search-forward ",")
 	     (setq name-end (1- (point)))
 	     (goto-char (or suffix-flag (point-max)))
-	     (or (eq ?\  (preceding-char))
+	     (or (eq ?\  (char-before))
 		 (insert ?\ ))
 	     (insert-buffer-substring (current-buffer) (point-min) name-end)
 	     (goto-char name-end)
@@ -1757,7 +1757,7 @@
       ;; *** This is probably completly unneeded now.
       ;;(goto-char (point-max))
       ;;(skip-chars-backward mail-extr-non-end-name-chars)
-      ;;(if (eq ?. (following-char))
+      ;;(if (eq ?. (char-after))
       ;;    (forward-char 1))
       ;;(narrow-to-region (point)
       ;;                  (progn

Index: lisp/packages/supercite.el
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/lisp/packages/supercite.el,v
retrieving revision 1.4
diff -u -r1.4 supercite.el
--- supercite.el	1997/04/10 05:55:40	1.4
+++ supercite.el	1997/06/11 00:10:07
@@ -1052,10 +1052,10 @@
 	(let ((bos 0)
 	      (eos (1- (length namestring))))
 	  (while (and (<= bos eos)
-		      (memq (aref namestring bos) '(32 ?\t)))
+		      (memq (aref namestring bos) '(?\  ?\t)))
 	    (setq bos (1+ bos)))
 	  (while (and (> eos bos)
-		      (memq (aref namestring eos) '(32 ?\t)))
+		      (memq (aref namestring eos) '(?\  ?\t)))
 	    (setq eos (1- eos)))
 	  (substring namestring bos (1+ eos))))))
 

-- 
steve@calag.com baur
Unsolicited commercial e-mail will be billed at $250/message.

