From xemacs-m  Thu Jun  5 16:30:15 1997
Received: from mercury.Sun.COM (mercury.Sun.COM [192.9.25.1])
	by xemacs.org (8.8.5/8.8.5) with SMTP id QAA17854
	for <xemacs-beta@xemacs.org>; Thu, 5 Jun 1997 16:30:14 -0500 (CDT)
Received: from Corp.Sun.COM ([129.145.35.78]) by mercury.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id OAA08273 for <xemacs-beta@xemacs.org>; Thu, 5 Jun 1997 14:48:30 -0700
Received: from legba.Corp.Sun.COM by Corp.Sun.COM (SMI-8.6/SMI-5.3)
	id OAA10819; Thu, 5 Jun 1997 14:30:38 -0700
Received: by legba.Corp.Sun.COM (SMI-8.6/SMI-SVR4)
	id OAA01037; Thu, 5 Jun 1997 14:30:37 -0700
To: xemacs-beta@xemacs.org
Subject: scroll-up defadvice now fails
X-Attribution: GDF
Mime-Version: 1.0 (generated by tm-edit 7.106)
Content-Type: text/plain; charset=US-ASCII
From: Gary.Foster@Corp.Sun.COM (Gary D. Foster)
Date: 05 Jun 1997 14:30:36 -0700
Message-ID: <bci4tbcivpf.fsf@corp.Sun.COM>
Lines: 29
X-Mailer: Gnus v5.4.55/XEmacs 20.3(beta3)

Noticed this in b3.

This bit of code worked fine in 20.2:

(defadvice scroll-up (around scroll-up freeze)
  (interactive "_P")
  (let ((zmacs-region-stays t))
    (if (interactive-p)
     	(condition-case nil
     	    ad-do-it
     	  (end-of-buffer (goto-char (point-max))))
      ad-do-it)))

However, in b3 I get the following error signalled when invoking this
advised scroll-up function:

Signaling: (wrong-number-of-arguments #<subr scroll-up (interactive)> 3)
  (ad-Orig-scroll-up-around-scroll-up n side window))
  (setq ad-return-value (ad-Orig-scroll-up-around-scroll-up n side window)))
  (condition-case nil (setq ad-return-value (ad-Orig-scroll-up-around-scroll-up n side window)) (end-of-buffer (goto-char ...))))
  (if (interactive-p) (condition-case nil (setq ad-return-value ...) (end-of-buffer ...)) (setq ad-return-value (ad-Orig-scroll-up-around-scroll-up n side window))))
  (let ((zmacs-region-stays t)) (if (interactive-p) (condition-case nil ... ...) (setq ad-return-value ...))))
  (let (ad-return-value) (let (...) (if ... ... ...)) ad-return-value))
  scroll-up(nil) call-interactively(scroll-up)

Now, I realize that the problem might be in my advice... if so, I'll
gladly fix it, but it *does* work just fine in 20.2.

-- Gary F.

