From xemacs-m  Mon May 12 00:04:08 1997
Received: from mercury.Sun.COM (mercury.Sun.COM [192.9.25.1])
	by xemacs.org (8.8.5/8.8.5) with SMTP id AAA26686
	for <xemacs-beta@xemacs.org>; Mon, 12 May 1997 00:04:07 -0500 (CDT)
Received: from Eng.Sun.COM ([129.146.1.25]) by mercury.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id WAA26445; Sun, 11 May 1997 22:16:39 -0700
Received: from kindra.eng.sun.com by Eng.Sun.COM (SMI-8.6/SMI-5.3)
	id WAA00298; Sun, 11 May 1997 22:03:32 -0700
Received: from xemacs.eng.sun.com by kindra.eng.sun.com (SMI-8.6/SMI-SVR4)
	id WAA22651; Sun, 11 May 1997 22:03:33 -0700
Received: by xemacs.eng.sun.com (SMI-8.6/SMI-SVR4)
	id WAA14830; Sun, 11 May 1997 22:03:28 -0700
Date: Sun, 11 May 1997 22:03:28 -0700
Message-Id: <199705120503.WAA14830@xemacs.eng.sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Martin Buchholz <mrb@Eng.Sun.COM>
To: Stig Bjorlykke <stigb@colargol.idb.hist.no>
Cc: xemacs-beta@xemacs.org
Subject: 20.2-b6: SUCCESS on intel-unknown-freebsd, but ...
In-Reply-To: <4rn2q2yv0k.fsf@gadid.idb.hist.no>
References: <4rn2q2yv0k.fsf@gadid.idb.hist.no>
X-Mailer: VM 6.24 under 20.1 XEmacs Lucid (beta15)
Reply-To: Martin Buchholz <mrb@Eng.Sun.COM>

>>>>> "Stig" == Stig Bjorlykke <stigb@colargol.idb.hist.no> writes:

Stig> ./configure  'i586-unknown-freebsd'

It's generally better to let XEmacs autodetect the configuration.

Stig> ... but I'm getting _alot_ of warnings like:

Stig> In file included from /usr/local/src/xemacs-20.2-b6/lib-src/make-docfile.c:53:
Stig> /usr/include/sys/param.h:46: warning: `BSD' redefined
Stig> ../src/s/freebsd.h:90: warning: this is the location of the previous definition

Stig> Is this a XEmacs or a FreeBSD "error"?

Seems like a FreeBSD error.  Someone familiar with various versions of 
FreeBSD will have to think about this code in src/s/freebsd.h:

/* this silences a few compilation warnings */
#undef BSD
#if __FreeBSD__ == 1
#define BSD 199103
#elif __FreeBSD__ == 2
#define BSD 199306
#elif __FreeBSD__ == 3
#define BSD 199506
#endif

In general, OS tests should be replaced by feature tests.  Most of the 
code using the BSD symbol looks pre-1990 vintage.

Martin

