From xemacs-m  Mon Apr 28 13:31:04 1997
Received: from mercury.Sun.COM (mercury.Sun.COM [192.9.25.1])
	by xemacs.org (8.8.5/8.8.5) with SMTP id NAA07628
	for <xemacs-beta@xemacs.org>; Mon, 28 Apr 1997 13:31:02 -0500 (CDT)
Received: from Corp.Sun.COM ([129.145.35.78]) by mercury.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id LAA15049 for <xemacs-beta@xemacs.org>; Mon, 28 Apr 1997 11:40:26 -0700
Received: from legba.Corp.Sun.COM by Corp.Sun.COM (SMI-8.6/SMI-5.3)
	id LAA02125; Mon, 28 Apr 1997 11:31:00 -0700
Received: by legba.Corp.Sun.COM (SMI-8.6/SMI-SVR4)
	id LAA05555; Mon, 28 Apr 1997 11:30:57 -0700
To: xemacs-beta@xemacs.org
Subject: sound.el patch
Mime-Version: 1.0 (generated by tm-edit 7.106)
Content-Type: multipart/mixed;
 boundary="Multipart_Mon_Apr_28_11:30:57_1997-1"
Content-Transfer-Encoding: 7bit
From: Gary.Foster@Corp.Sun.COM (Gary D. Foster)
Date: 28 Apr 1997 11:30:57 -0700
Message-ID: <bcirafvhue6.fsf@corp.Sun.COM>
Lines: 58
X-Mailer: Gnus v5.4.46/XEmacs 20.2(beta3)

--Multipart_Mon_Apr_28_11:30:57_1997-1
Content-Type: text/plain; charset=US-ASCII

20.2-b3 gives me the following backtrace on (load-default-sound):


--Multipart_Mon_Apr_28_11:30:57_1997-1
Content-Type: application/octet-stream
Content-Disposition: attachment; filename="backtrace"
Content-Transfer-Encoding: 8bit

Signaling: (error "volume not an integer or nil")
  signal(error ("volume not an integer or nil"))
  cerror("volume not an integer or nil")
  apply(cerror "volume not an integer or nil")
  error("volume not an integer or nil")
  load-sound-file("bass-snap.au" bass 80)
  eval((load-sound-file "bass-snap.au" (quote bass) 80))
  mapc-internal(eval ((load-sound-file "drum-beep.au" (quote drum)) (load-sound-file "quiet-beep.au" (quote quiet)) (load-sound-file "bass-snap.au" (quote bass) 80) (load-sound-file "whip.au" (quote whip) 70) (load-sound-file "cuckoo.au" (quote cuckoo)) (load-sound-file "yeep.au" (quote yeep)) (load-sound-file "hype.au" (quote hype) 100)))
  mapc(eval ((load-sound-file "drum-beep.au" (quote drum)) (load-sound-file "quiet-beep.au" (quote quiet)) (load-sound-file "bass-snap.au" (quote bass) 80) (load-sound-file "whip.au" (quote whip) 70) (load-sound-file "cuckoo.au" (quote cuckoo)) (load-sound-file "yeep.au" (quote yeep)) (load-sound-file "hype.au" (quote hype) 100)))
  #<compiled-function (from "sound.elc") nil "...(22)" [message "Loading sounds..." nil sound-alist mapc eval sound-load-alist append sound-default-alist "Loading sounds...done"] 3 ("/home/gfoster/xemacs-20.2-b3/lisp/prim/sound.elc" . 3729) nil>()
  call-interactively(load-default-sounds)
  command-execute(load-default-sounds t)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

I fixed it with the following tiny patch to lisp/prim/sound.el (boy I hope
I did this right...)


--Multipart_Mon_Apr_28_11:30:57_1997-1
Content-Type: application/octet-stream; type=patch
Content-Disposition: attachment; filename="sound.el.patch"
Content-Transfer-Encoding: 7bit

--- lisp/prim/sound.el.orig	Mon Apr 28 10:35:17 1997
+++ lisp/prim/sound.el	Mon Apr 28 11:05:44 1997
@@ -80,7 +80,7 @@
     (load-sound-file "quiet-beep.au"	'quiet)
     (load-sound-file "bass-snap.au"	'bass 80)
     (load-sound-file "whip.au"		'whip 70)
-    (load-sound-file "cuckoo.au"		'cuckoo)
+    (load-sound-file "cuckoo.au"	'cuckoo)
     (load-sound-file "yeep.au"		'yeep)
     (load-sound-file "hype.au"		'hype 100)
     )
@@ -131,7 +131,8 @@
   (unless (symbolp sound-name)
     (error "sound-name not a symbol"))
   (unless (null volume)
-    (integerp volume) (error "volume not an integer or nil"))
+    (unless (integerp volume)
+      (error "volume not an integer or nil")))
   (let (buf
 	data
 	(file (locate-file filename  default-sound-directory-list  sound-ext)))

--Multipart_Mon_Apr_28_11:30:57_1997-1--

