From xemacs-m  Wed Apr 23 03:54:59 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id DAA23725
	for <xemacs-beta@xemacs.org>; Wed, 23 Apr 1997 03:54:58 -0500 (CDT)
Received: (from hniksic@localhost)
          by jagor.srce.hr (8.8.5/8.8.4)
	  id KAA16114; Wed, 23 Apr 1997 10:54:54 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: The status of gnuattach lossage
References: <kigwwpvqidt.fsf@jagor.srce.hr> <byk9lv14f6.fsf@midget.math.ethz.ch> <kigzpuqz1w1.fsf@jagor.srce.hr> <by3esixip2.fsf@midget.math.ethz.ch>
X-URL: ftp://gnjilux.cc.fer.hr/pub/unix/util/wget/
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 23 Apr 1997 10:54:53 +0200
In-Reply-To: Jan Vroonhof's message of 23 Apr 1997 10:11:05 +0200
Message-ID: <kigenc2yv8i.fsf@jagor.srce.hr>
Lines: 31
X-Mailer: Gnus v5.4.45/XEmacs 19.15

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> It can in priniple be run from kill-buffer-kook, but that would make
> it more unriable. The user could change the hook of course.

No.  The user who changes `kill-buffer-hook' is assumed to know what
he is doing.  A typical user will do it with `add-hook' anyway.

`kill-buffer-hook' is not a user-variable.

> More importantly if you look at the kill-buffer C code, there are
> still a lot of failure points after the hook is called. It could
> leave us with a unkilled buffer, but the client already thinking it
> has onctrol back.

Then the code should be changed, or another hook provided.  That was
my point.

Aliasing an internal function should really be avoided.  Always.

> I am also not sure whether aliasing kill-buffer was a delibirate
> decision or just due to fact that gnuserv is so old it existed before
> there was a kill-buffer-hook.

Good point.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Then...  his face does a complete change of expression.  It goes from
a "Vengeance is mine" expression, to a "What the fuck" blank look.

