From xemacs-m  Fri Apr 11 20:23:14 1997
Received: from venus.Sun.COM (venus.Sun.COM [192.9.25.5])
	by xemacs.org (8.8.5/8.8.5) with SMTP id UAA14667
	for <xemacs-beta@xemacs.org>; Fri, 11 Apr 1997 20:23:13 -0500 (CDT)
Received: from Eng.Sun.COM ([129.146.1.25]) by venus.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id SAA04536; Fri, 11 Apr 1997 18:22:43 -0700
Received: from kindra.eng.sun.com by Eng.Sun.COM (SMI-8.6/SMI-5.3)
	id SAA23004; Fri, 11 Apr 1997 18:22:41 -0700
Received: from xemacs.eng.sun.com by kindra.eng.sun.com (SMI-8.6/SMI-SVR4)
	id SAA19438; Fri, 11 Apr 1997 18:22:38 -0700
Received: by xemacs.eng.sun.com (SMI-8.6/SMI-SVR4)
	id SAA26817; Fri, 11 Apr 1997 18:22:36 -0700
Date: Fri, 11 Apr 1997 18:22:36 -0700
Message-Id: <199704120122.SAA26817@xemacs.eng.sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Martin Buchholz <mrb@Eng.Sun.COM>
To: wmperry@aventail.com
Cc: xemacs-beta@xemacs.org
Subject: patch for (button-release-p (allocate-event)) crash
In-Reply-To: <199704102236.PAA06863@newman>
References: <199704102236.PAA06863@newman>
Reply-To: Martin Buchholz <mrb@Eng.Sun.COM>

>>>>> "Bill" == William M Perry <wmperry@aventail.com> writes:

Bill> Ah, the joy of abort().
Bill> -Bill P.

Bill> *** events.c	1997/04/10 23:08:07	1.1
Bill> --- events.c	1997/04/10 23:08:10
Bill> ***************
Bill> *** 1131,1137 ****
Bill>         return Qmagic;
  
Bill>       default:
Bill> -       abort ();
Bill>         return Qnil;
Bill>       }
Bill>   }
Bill> --- 1131,1136 ----


No, No, No.  Please apply the patch I posted earlier to
comp.emacs.xemacs. 

A word about removing abort()'s from the code.  They are there for a
reason - assertions - and they are not to be removed unless it is
clearly understood that they do not belong.  In this case the abort()
was an assertion that all the cases in the switch were present, which
was not true.

If we did 

#define abort()

XEmacs would crash less often, and many bugs would become much harder to fix.

Martin

