From xemacs-m  Thu Apr 10 10:52:48 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id KAA23275
	for <xemacs-beta@xemacs.org>; Thu, 10 Apr 1997 10:52:47 -0500 (CDT)
Received: (from hniksic@localhost)
          by jagor.srce.hr (8.8.5/8.8.4)
	  id RAA14599; Thu, 10 Apr 1997 17:52:45 +0200 (MET DST)
Sender: hniksic@public.srce.hr
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: make-mode.el is customized
References: <kig7mibdexh.fsf@jagor.srce.hr> <rjiv1v1c6t.fsf@zuse.dina.kvl.dk>
X-URL: ftp://gnjilux.cc.fer.hr/pub/unix/util/wget/
X-Attribution: Hrv
X-Face: &}4JQk=L;e.~x+|eo]#DGk@x3~ed!.~lZ}YQcYb7f[WL9L'Z*+OyA\nA
        EL1M(".[qvI#a2E6WYI5>>e7'@_)3Ol9p|Nn2wNa/;~06jL*B%tTcn/X
        vhAu7qeES0\|MF%$;sI#yn1+y"
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 10 Apr 1997 17:52:45 +0200
In-Reply-To: Per Abrahamsen's message of 10 Apr 1997 11:04:10 +0200
Message-ID: <kign2r627ua.fsf@jagor.srce.hr>
Lines: 39
X-Mailer: Gnus v5.4.42/XEmacs 19.15

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> To be compatible with people who have set this variable:

OK, but that is compatibility only.  Setting faces through variables
is highly frowned upon in XEmacs (and rightly so).  Look at the XEmacs
documentation for `font-lock-reference-face' variable as an
example. :-)

> (defcustom makefile-space-face 'makefile-space-face
>   "Face to use for highlighting leading spaces in Font-Lock mode."
>   :type 'face
>   :group 'makefile-mode)

OK.

> (defface makefile-space-face
>   '((((class color))
>      (:background "hotpink"))		; Yeah!
>     ;; Everything else, just choose the most visible background
>     ;; color.  We don't care about foreground, since it is only used
>     ;; for whitespace.
>     (((background light))
>       (:background "black"))
>     (((background dark))
>       (:background "white")))
>   "Face to use for highlighting leading spaces in Font-Lock mode."
>   ;; Don't add a :group, since people can access it through the variable.
>   )

I think we do need a group, as the variable is obsolete.  My patch
also removes the references to the variable (it was referenced only in
font-lock-keywords anyway).

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
`VI' - An editor used by those heretics that don't subscribe to
       the Emacs religion.

