From xemacs-m  Thu Apr  3 16:31:32 1997
Received: from jens.metrix.de (jens@jens.metrix.de [194.123.88.124])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id QAA28240
	for <xemacs-beta@xemacs.org>; Thu, 3 Apr 1997 16:31:28 -0600 (CST)
Received: (from jens@localhost) by jens.metrix.de (8.7.6/8.7.3) id AAA00593; Fri, 4 Apr 1997 00:30:48 +0200
To: XEmacs Beta Mailing List <xemacs-beta@xemacs.org>
Subject: Re: display-time timewarp in 19.15
References: <9704031926.AA19700@gsdws133.it.gcm.com> <rvwwqjrga0.fsf@sdnp5.ucsd.edu>
X-Face: Z[@OB)("ZvE?ev~1b+b!0ZUB.$%rh.9qE>dVf>q}Q/V?%d`J3gd!LR\aAZ8<Hwi]xTA(:*c;i3,?K?+rCy*^b$)a,}E?eo},}x2]5LlJysyoUOK"o[>K)'\Ulb7y-7*.If^;rHl['oa)n_M7E6w+LDKMs"G8_`c)uOS1^}.1|8Ill]7X68X-paeUOpBhz<F`B0?~^2Et~GYfw~/0]H]nx4~C_E/_mp#^7Ixc:
Reply-To: jens@lemming0.lem.uni-karlsruhe.de
Mime-Version: 1.0 (generated by tm-edit 7.106)
Content-Type: text/plain; charset=US-ASCII
From: Jens Lautenbacher <jens@metrix.de>
Date: 04 Apr 1997 00:30:47 +0200
In-Reply-To: David Moore's message of 03 Apr 1997 12:40:55 -0800
Message-ID: <m3u3lneo2w.fsf@jens.metrix.de>
Lines: 38
X-Mailer: Gnus v5.4.37/XEmacs 20.1(beta10)

David Moore <dmoore@ucsd.edu> writes:

> David Worenklein <dcw@gcm.com> writes:
> 
> > When my clock jumps, the frame splits in half, and the bottom window
> > shows a subset of my .diary (those entries that apply to today).  I'm
> > not sure that the diary kicked off each time that clock warped, but I
> > did notice it the last two times.
> 
> Yeah, appt.el does all sorts of hooking into display-time.  This hackery
> is simply to add a new variable `display-time-hook' which gets called
> everytime `display-time-function' gets run.  But the time.el with XEmacs
> 19.15 already has display-time-hook run in that manner.
The calling of display time hook is unchanged from the 19.14 version.

> So it's getting run twice.  I don't know if that's specifically the
> problem, but it is a problem.
Indeed.
 
> appt.el also does a (setq display-time-hook 'appt-check) which is evil.
> It should use add-hook.
Oh no. Now *that* *is* evil... 
 
> Jens, can we have a variable like display-time-version which could be
> used for things like this?
I posted 1.12 to Steve before seeing this. I'll make a patch real soon 
now.
 
> 
> Possible untested patch here. :)  It's not clear that this is the entire
> problem, but probably running those hooks twice every clock step isn't a
> great idea.

I don't use appt.el so I can't comment on this. Would somebody who
tests it let me (or/and the list) know if this works?


      jtl

