From xemacs-m  Thu Dec 12 14:28:22 1996
Received: from gwa.ericsson.com (gwa.ericsson.com [198.215.127.2]) by xemacs.cs.uiuc.edu (8.8.3/8.8.3) with ESMTP id OAA04578 for <xemacs-beta@xemacs.org>; Thu, 12 Dec 1996 14:28:21 -0600 (CST)
Received: from mr1.exu.ericsson.se (mr1.exu.ericsson.com [138.85.147.11]) by gwa.ericsson.com (8.8.2/8.8.2) with ESMTP id OAA14542 for <xemacs-beta@xemacs.org>; Thu, 12 Dec 1996 14:27:51 -0600 (CST)
Received: from screamer.rtp.ericsson.se (screamer.rtp.ericsson.se [147.117.133.13]) by mr1.exu.ericsson.se (8.7.1/NAHUB-MR1.1) with SMTP id OAA03724 for <xemacs-beta@xemacs.org>; Thu, 12 Dec 1996 14:27:51 -0600 (CST)
Received: from rcur (rcur18.rtp.ericsson.se [147.117.133.138]) by screamer.rtp.ericsson.se (8.6.12/8.6.4) with ESMTP id PAA05739 for <xemacs-beta@xemacs.org>; Thu, 12 Dec 1996 15:27:50 -0500
To: XEmacs Mailing List <xemacs-beta@xemacs.org>
Subject: 20.0-b30:  bug in ilisp
Mime-Version: 1.0 (generated by tm-edit 7.94)
Content-Type: text/plain; charset=US-ASCII
Date: Thu, 12 Dec 1996 15:27:49 -0500
Message-ID: <15113.850422469@rtp.ericsson.se>
From: Raymond Toy <toy@rtp.ericsson.se>


Found a small bug in ilisp-out.el.  It checks for emacs-minor-version
less than 12 without checking emacs-major-version.  Ilisp isn't able
to open a new window because it uses window-edges.  A simple fix is
enclosed.

For true portability, I think some of the code needs to be rethought.
For example +ilisp-emacs-minor-version-number+ is always 14 because it
xemacs.  But then in ilisp-out.el, we use emacs-minor-version to find
out the version instead of using +ilisp-emacs-minor-version+.  There
are other bugs like that.  I'd fix them, but I'm not exactly sure of
the intent of the original author

Ray

Patch for ilisp-out.el

--- ilisp-out.el~	Fri Nov  8 00:14:26 1996
+++ ilisp-out.el	Thu Dec 12 15:22:24 1996
@@ -262,7 +262,8 @@
   "Find the window directly below us, if any.  This is probably the 
  window from which enlarge-window would steal lines."
   (if (or (not (string-match "XEmacs" emacs-version))
-	  (< emacs-minor-version 12))
+	  (and (= emacs-major-version 19)
+	       (< emacs-minor-version 12)))
       (let* ((bottom (nth 3 (window-edges window)))
 	     (window* nil)
 	     (win window))
@@ -279,7 +280,8 @@
 (defun ilisp-find-top-left-most-window ()
   "Return the leftmost topmost window on the current screen."
   (if (or (not (string-match "XEmacs" emacs-version))
-	  (< emacs-minor-version 12))
+	  (and (= emacs-major-version 19)
+	       (< emacs-minor-version 12)))
       (let* ((window* (selected-window))
 	     (edges* (window-edges window*))
 	     (win nil)

