From xemacs-m  Fri Feb  7 10:36:53 1997
Received: from portofix.ida.liu.se (portofix.ida.liu.se [130.236.177.25])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id KAA08152
	for <xemacs-beta@xemacs.org>; Fri, 7 Feb 1997 10:36:52 -0600 (CST)
Received: from sen2.ida.liu.se (sen2.ida.liu.se [130.236.176.112]) by portofix.ida.liu.se (8.8.3/8.8.3) with SMTP id RAA22936 for <xemacs-beta@xemacs.org>; Fri, 7 Feb 1997 17:36:51 +0100 (MET)
Received: by sen2.ida.liu.se (SMI-8.6/ida.slave-V1.0b6d6S2)
	id RAA29564; Fri, 7 Feb 1997 17:36:50 +0100
Date: Fri, 7 Feb 1997 17:36:50 +0100
Message-Id: <199702071636.RAA29564@sen2.ida.liu.se>
From: David Byers <davby@ida.liu.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: xemacs-beta@xemacs.org
Subject: Re: 20.0 --with-mule segfaults when viewing Japanese
In-Reply-To: <kighgjo4nav.fsf@jagor.srce.hr>
References: <yviasp3digdf.fsf@atreides.mindspring.com>
	<199702041227.NAA17114@sen2.ida.liu.se>
	<kig6808gqbw.fsf@jagor.srce.hr>
	<199702070342.TAA14213@xemacs.eng.sun.com>
	<199702071422.PAA29298@sen2.ida.liu.se>
	<kighgjo4nav.fsf@jagor.srce.hr>
X-Face: (@~#v$c[GP"T}a;|MU<%Dpm5*6yv"NR|7k;uk8MAISFxdZ(Og$C{u(j"9X7v$qonp}SKfhT
 g|5[Pu~/3F7XQEk70gK'4z%1R%%gg7]}=>/jD`qcBeHDgo&HS,^S!&.zoTSxh<>-O6EB?SSy96&m37

> I believe Martin tried to say that the real fix would be to find the
> *particular* place accessing the display table erroneously, and fixing
> that, instead of adding bounds checking in *all* cases.

I found all those places before attempting to fix anything. There are
two places in the code that look in the display tables using the macro
I changed, and those are within three lines of each other.

The first needs bounds checking. The second *could* to without since
it is called only if the first lookup finds an entry in the display
table (which implies that the character is within the bounds of the
display table) but the miniscule performance gain to me isn't worth
the loss of clarity resulting from the use of two nearly identical
but subtly different macros. Others may disagree.

--
David Byers.

