From xemacs-m  Fri Sep 26 13:46:08 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id NAA26680
	for <xemacs-beta@xemacs.org>; Fri, 26 Sep 1997 13:46:07 -0500 (CDT)
Received: (from steve@localhost)
	by altair.xemacs.org (8.8.7/8.8.7) id LAA14867;
	Fri, 26 Sep 1997 11:52:18 -0700
Mail-Copies-To: never
To: xemacs-beta@xemacs.org
Subject: Re: [patch] help (includes newest find-func)
References: <lbafh0nsx7.fsf@boron.kurims.kyoto-u.ac.jp> <kig4t78jgb1.fsf@jagor.srce.hr>
X-Face: (:YAD@JS'&Kz'M}n7eX7gEvPR6U1mJ-kt;asEc2qAv;h{Yw7ckz<7+X_SYeTNAaPui:e~x$
 ,A=gkt*>UPL/}\a/#C~v2%ETiAY_sx;xve0yL??JWTtX_-NUzXyP38UdW#cmN1\4(X!c3m#%IbtB-3
 Z-!xpZi!`E.s{(;aP=b11"!3wQu]1j@^V|;n=B|{l<bZV1.AI`zWV%kPCnUhcgEe\(}/_kNd6,*3ZJ
 Q3o<YQ3^u;7jS=:p0--u3msQO
X-Attribution: sb
From: SL Baur <steve@xemacs.org>
In-Reply-To: Hrvoje Niksic's message of "26 Sep 1997 16:33:22 +0200"
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
Date: 26 Sep 1997 11:52:18 -0700
Message-ID: <m2bu1fewm5.fsf@altair.xemacs.org>
Lines: 51
X-Mailer: Quassia Gnus v0.10/XEmacs 20.3(beta24) - "Ljubljana"

Hrvoje Niksic <hniksic@srce.hr> writes:

> Jens-Ulrik Holger Petersen <petersen@kurims.kyoto-u.ac.jp> writes:
>> -    (if file-name
>> -	(princ (format "  -- loads from \"%s\"\n" file-name) stream))
>> -    (if home
>> -	(princ (format "  -- loaded from \"%s\"\n" home)) stream)
>> +    (if (or home file-name)
>> +	(princ (format "  -- defined in \"%s\"\n" (or home file-name)) stream))

> I don't like this change.  There was a distinction between "loads
> from" and "loaded from", which is now gone.  For instance:

;; I agree with Hrvoje.

> In this case, this may be fine, but there are cases where I want to
> see the autoload, too.

Especially with the way autoloads are being modified in this beta
cycle.  We can consider removing the autoloads information once we go
to beta9x.

> Hmm.  This is not good.  `locate-library' knows about compression
> itself (look at packages.el), so it is unnecessary to duplicate that
> work here.

Right.

> I thought one of my patches addressed it?  Hmm.  It was probably one
> of those that were unintentionally delayed for b24.

Which patch are you referring to?  As far as I was aware, I applied
all your patches in the incoming queue for beta23.

> In my copy of help.el the code looks like this:

> ...
>     (let* ((path (or path find-function-source-path))
> 	   (filename (or (locate-library (concat library ".el") t path)
> 			 (locate-library library t path))))
>       (if (not filename)
> 	  (error "The library \"%s\" is not in the path." library))
> ...

> And that's it.  Steve, what does that part look in your copy?

As you cited it.

> Otherwise, the patches are fine!  I also like the fact that you added
> the appropriate histories to minibuffer prompts.

