From xemacs-m  Wed Sep 24 13:26:21 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id NAA03046
	for <xemacs-beta@xemacs.org>; Wed, 24 Sep 1997 13:26:17 -0500 (CDT)
Received: (from hniksic@localhost)
	by jagor.srce.hr (8.8.7/8.8.6) id UAA16599;
	Wed, 24 Sep 1997 20:26:19 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Prettification of keymap
X-Attribution: Hrvoje
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 24 Sep 1997 20:26:19 +0200
Message-ID: <kigafh2y3ec.fsf@jagor.srce.hr>
Lines: 40
X-Mailer: Quassia Gnus v0.10/XEmacs 20.3(beta23) - "Sarajevo"

`keymap.c' contains the following function:

static Lisp_Object
make_key_description (CONST struct key_data *key)
{
  Lisp_Object keysym = key->keysym;
  unsigned int modifiers = key->modifiers;

  if (prettify && CHARP (keysym))
    {
      /* This is a little slow, but (control a) is prettier than (control 65).
	 It's now ok to do this for digit-chars too, since we've fixed the
	 bug where \9 read as the integer 9 instead of as the symbol with
	 "9" as its name.
       */
      /* !!#### I'm not sure how correct this is. */
      Bufbyte str [1 + MAX_EMCHAR_LEN];
      Bytecount count = set_charptr_emchar (str, XCHAR (keysym));
      str[count] = 0;
      keysym = intern ((char *) str);
    }
  return control_meta_superify (keysym, modifiers);
}


I think the PRETTIFY argument is totally unnecessary in XEmacs 20, as
we clearly distinguish ?a from 97, etc.  So, it won't be (control 97), 
but (control ?a).  So, there is no need for the slowdown involved with 
interning the strings, and all the fuss.

I have removed the PRETTIFY argument, and modified the callers
accordingly, and nothing seems to be breaking.  This will be the
default in 20.3-b24.  So, open your eyes: if anything breaks from
Sarajevo -> Ljubljana in the keymaps area, this might be the culprit.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
"Silence!" cries Freydag. "I did not call thee in for a consultation!" 
"They are my innards! I will not have them misread by a poseur!"

