From xemacs-m  Sun Jan 12 20:15:56 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
          by xemacs.org (8.8.4/8.8.4) with ESMTP
	  id UAA02701 for <xemacs-beta@xemacs.org>; Sun, 12 Jan 1997 20:15:56 -0600 (CST)
Received: (from steve@localhost)
          by altair.xemacs.org (8.8.4/8.8.4)
	  id SAA25316; Sun, 12 Jan 1997 18:25:55 -0800
Sender: steve@xemacs.org
To: xemacs-beta@xemacs.org
Subject: Re: 19.15b90: [PATCH] window.el: shrink-window-if-larger-than-buffer
References: <QQbyfi01495.199701122039@crystal.WonderWorks.COM> 	<97Jan12.173254edt.10634(1)@jupiter.scs.Ryerson.CA> 	<m2hgkmea12.fsf@altair.xemacs.org> <QQbygb02393.199701130125@crystal.WonderWorks.COM>
X-Url: http://www.miranova.com/%7Esteve/
Mail-Copies-To: never
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@miranova.com>
In-Reply-To: Kyle Jones's message of Sun, 12 Jan 1997 20:25:43 -0500 (EST)
Mime-Version: 1.0 (generated by tm-edit 7.100)
Content-Type: text/plain; charset=US-ASCII
Date: 12 Jan 1997 18:25:54 -0800
Message-ID: <m2hgkm2tvx.fsf@altair.xemacs.org>
Lines: 23
X-Mailer: Red Gnus v0.80/XEmacs 20.0

Kyle Jones writes:

> But if you're going to rewrite that function anyway, be careful.
> There is some subtlely involved.  You can't use forward-line to
> select the proper window height, for instance.  This will loses on
> wrapped lines.

Yup.  Repeat by `C-h v ccl-read-vscii'.

 ...

> Since it's both late and a tricky function I vote for saving the
> rewrite until after the release.  The really bad thing, the
> buffer ordering problem, is taken care of with a much smaller
> code change.

Kyle's patch exhibits none of the problems of the rewrite patch, so it
gets my vote as well.  The problem is worth revisiting after release
because it is a yucky algorithm.
-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be billed at $250/message.
Today's environment is 20.0 XEmacs Lucid (beta91) and Red Gnus v0.80

