From xemacs-m  Fri Jan 10 00:59:35 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
          by xemacs.cs.uiuc.edu (8.8.4/8.8.4) with ESMTP
	  id AAA22524 for <xemacs-beta@xemacs.org>; Fri, 10 Jan 1997 00:59:35 -0600 (CST)
Received: (from steve@localhost)
          by altair.xemacs.org (8.8.4/8.8.4)
	  id XAA06245; Thu, 9 Jan 1997 23:09:39 -0800
Sender: steve@xemacs.org
To: xemacs-beta@xemacs.org
Subject: Re: a bad test for XFree86 in configure
References: <xcdsp4eb7en.fsf@gargoyle164.cs.uchicago.edu> 	<m2g20d1lbj.fsf@altair.xemacs.org> 	<xcdhgkroer5.fsf@gargoyle164.cs.uchicago.edu> <199701091736.JAA23191@xemacs.eng.sun.com>
X-Url: http://www.miranova.com/%7Esteve/
Mail-Copies-To: never
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@miranova.com>
In-Reply-To: Martin Buchholz's message of Thu, 9 Jan 1997 09:36:02 -0800
Mime-Version: 1.0 (generated by tm-edit 7.100)
Content-Type: text/plain; charset=US-ASCII
Date: 09 Jan 1997 23:09:35 -0800
Message-ID: <m2ybe2ypjk.fsf@altair.xemacs.org>
Lines: 47
X-Mailer: Red Gnus v0.80/XEmacs 20.0

Martin Buchholz writes:

> Looking at the big picture, why are we trying to detect XFree86 at
> all??  Isn't this just another X11 implementation?

 ...

> In general,

> #ifdef XFREE86

> is just ...  evil.

Good point.  Why do we need it?

$ cd /usr/src
$ grep XFREE xemacs-(19.15|20.0)/(lwlib|lib-src|src)/*.[ch]
xemacs-19.15/src/config.h:#define HAVE_XFREE386 1
xemacs-20.0/src/config.h:#define HAVE_XFREE386 1

It doesn't appear to be used by anything in the code, which is as it
should be.

Finding libraries, etc. is not an excuse because shouldn't we be using
xmkmf or configure library detection for that?

I see:
    # On UnixWare 2.1 we must kludge harder to try to detect Xmu
    # Upgrade to autoconf 2 and use ac_check_lib - mrb
    if test "${with_xmu}" != "yes" && test -f "/.UpgradeVer2.1" ; then
      # begin expansion of ac_have_library
      ac_save_LIBS="${LIBS}"
      if test x$HAVE_XFREE386 = xyes; then
        LIBS="-lXt -lSM -lICE ${LIBS}"
      else
        LIBS="${LIBS} -lXmu -lXt -lXext -lX11"
      fi

in configure, which is plain wrong.  The existence and requirement of
-lSM, -lICE, and -lXext should be tested for explicitly.

Why don't you just go ahead and wipe it out of existence?
-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be billed at $250/message.
"That Bill Clinton.  He probably doesn't know how to log on to the
Internet."  -- Rush Limbaugh, noted Computer Expert

