From xemacs-m  Sat Jul 12 09:30:57 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id JAA00418
	for <xemacs-beta@xemacs.org>; Sat, 12 Jul 1997 09:30:54 -0500 (CDT)
Received: (from hniksic@localhost)
	by jagor.srce.hr (8.8.6/8.8.6) id QAA11188;
	Sat, 12 Jul 1997 16:30:52 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: save-some-buffers bug
References: <199707111711.NAA04541@simple.sst.ll.mit.edu> <QQcxtv10207.199707111947@crystal.WonderWorks.COM> <kigiuyhtkug.fsf@jagor.srce.hr> <m2wwmxort4.fsf@altair.xemacs.org>
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 12 Jul 1997 16:30:52 +0200
In-Reply-To: Steven L Baur's message of "11 Jul 1997 20:47:03 -0700"
Message-ID: <kig90zcs5pf.fsf@jagor.srce.hr>
Lines: 41
X-Mailer: Gnus v5.4.59/XEmacs 20.3(beta12) - "Helsinki"

Steven L Baur <steve@xemacs.org> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> 
> > Well, I don't see a good reason to delete other windows, anyway.
> 
> If you start saving from a tiny window the whole feature is
> pointless.  A better possibility might be to do the
> delete-other-windows only on the first time through the loop.

This sounds like a good idea.  This patch should fix it all (to be
applied on top of my previous patch):

--- lisp/prim/files.el.orig	Sat Jul 12 16:28:56 1997
+++ lisp/prim/files.el	Sat Jul 12 16:29:52 1997
@@ -2283,6 +2283,7 @@
   (interactive "P")
   (save-excursion
     (save-window-excursion
+    (delete-other-windows)
     ;; XEmacs - do not use queried flag
     (let ((files-done
 	   (map-y-or-n-p
@@ -2303,9 +2304,7 @@
 		      (when save-some-buffers-query-display-buffer
 			(when (condition-case nil
 				  (switch-to-buffer buffer t)
-				(error nil))
-			  ;(delete-other-windows)))
-			  ))
+				(error nil))))
 		      (if (buffer-file-name buffer)
 			  (format "Save file %s? "
 				  (buffer-file-name buffer))


-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
"Beware of bugs in the above code; I have only proved it correct,
not tried it."                                    -- Donald Knuth

